Using with dataloader-php throws "Could not resolve promise" Exception

[n1ru4l]

I have three types

type Questionnaire {
  id: Int!
  blocks: [Int]!
}

type Block {
  id: Int!
  wrappers: [Wrapper]!
}

type Wrapper {
  id: Int!
  questions: [Question]!
}

type Question {
  id: Int!
}

type Query {
  questionnaire(questionnaireId: Int!): Questionnaire
  wrapper(wrapperId: Int!): Wrapper
}

Every field that returns a list uses a DataLoader (like in https://github.com/overblog/dataloader-php#using-with-webonyxgraphql). Each DataLoader is identical, despite the tables from which the dataloaders fetch their data.

The following query works fine:

query questionnaire {
  questionnaire(questionnaireId: 1) { # no dataloader
    blocks { # resolver uses dataloader
      wrappers { # resolvers uses dataloader
        id
      }
    }
  }
}

However going one level deeper results in an exception.

query questionnaire {
  questionnaire(questionnaireId: 1) { # no dataloader
    blocks { # resolver uses dataloader
      wrappers { # resolvers uses dataloader
        id
        questions { # resolver uses dataloader
          id
        }
      }
    }
  }
}

InvariantViolation in SyncPromiseAdapter.php line 151:
Could not resolve promise

When I log the status of the promise I get pending.

According to the code this should not happen. https://github.com/webonyx/graphql-php/blob/master/src/Executor/Promise/Adapter/SyncPromiseAdapter.php#L132

When I use the following query (only 2 dataloader) everything is behaving like excpected:

query wrapper {
  wrapper(wrapperId: 1) { # resolvers uses dataloader
    id
    questions { # resolver uses dataloader
      id
    }
  }
}

Edit: This also happens in this resolver function where I chain multiple promises (I am using laravel):

public function resolveIsValidField($questionnaire, $args, $context) {
  $questionnaireId = is_array($questionnaire) ? $questionnaire['id'] : $questionnaire->id;
  /** @var BlockRepositoryInterface $blockRepository */
  $blockRepository = $context['repositories']['blocks'];
  /** @var WrapperRepositoryInterface $wrapperRepository */
  $wrapperRepository = $context['repositories']['wrappers'];
  /** @var QuestionRepositoryInterface $questionRepository */
  $questionRepository = $context['repositories']['questions'];

  $blocks = null;
  $wrappers = null;

  return $blockRepository->findWhereQuestionnaireId($questionnaireId)
    ->then(function (Collection $blockRecords) use (&$blocks, $wrapperRepository) {
      $blocks = $blockRecords;
      $bockIds = $blocks->map(function (Block $block) {
        return $block->id;
      })->toArray();

      return $wrapperRepository->getWhereBlockIds($bockIds);
    })
    ->then(function ($wrapperRecords) use (&$wrappers, $questionRepository) {
      $wrappers = collect($wrapperRecords)->flatten();
      $wrapperIds = $wrappers->pluck('id');
      return $questionRepository->getWhereWrapperIds($wrapperIds->toArray());
    })
    ->then(function ($questionRecords) use (&$blocks, &$wrappers) {
      $questions = collect($questionRecords)->flatten();

      return isQuestionnaireValid($blocks, $wrappers, $questions);
    });
}

[vladar]

I am curious, have you tried the same with just GraphQL\Deferred (without DataLoader)?

Looks like DataLoader project wraps original adapter, so it's hard to say without digging deeper if this is a bug in this library or in DataLoader.

@mcg-web any thoughts?

[n1ru4l]

@vladar Could you give me an example on how I could achieve something like the code I added in my last edit with GraphQL\Deferred?

I will try to setup a reproduction repository using laravel-graphql and dataloader-php.

[mcg-web]

@vladar without a complete use case it will be difficult to give my help on this... @n1ru4l with a complete example I can maybe get what going wrong :)

[n1ru4l]

@mcg-web Here is my reproduction repository: https://github.com/n1ru4l/laravel-graphql-dataloader-php-exception-reproduction

The relevant files are the Service Provider (app/Providers/AppServiceProvider.php), the types and queries app/GraphQL/* and the DataLoaders app/DataLoader/*.php

You will not need any database setup just use php artisan serve.

You can navigate to graphiql on /graphiql.

This query fails:

query type1 {
  type1 {
    __typename
    id
    items {
      __typename
      id
      items {
        __typename
        id
        items {
          __typename
          id
        }
      }
    }
  }

This query works:

query type1 {
  type1 {
    __typename
    id
    items {
      __typename
      id
    }
  }
}

[vladar]

I forked your repo and replaced DataLoaders with regular GraphQL\Deferred calls. It works as expected.

I guess the bug is somewhere on DataLoader side.

[n1ru4l]

@vladar Thank you for the fast response :) Is there any option to move this issue to dataloader-php repository?

[mcg-web]

I am trying to get why @n1ru4l . if I don't get i'll create the issue on dataloader repository :)

[n1ru4l]

OK cool, also thank you for the fast responses :)

[vladar]

@mcg-web If I add DataLoader::await() to queue progression, it works, e.g.:

    /**
     * Synchronously wait when promise completes
     *
     * @param Promise $promise
     * @return mixed
     */
    public function wait(Promise $promise)
    {
        $dfdQueue = Deferred::getQueue();
        $promiseQueue = SyncPromise::getQueue();

        while (
            $promise->adoptedPromise->state === SyncPromise::PENDING &&
            !($dfdQueue->isEmpty() && $promiseQueue->isEmpty())
        ) {
            Deferred::runQueue();
            SyncPromise::runQueue();
            DataLoader::await();
        }

        /** @var SyncPromise $syncPromise */
        $syncPromise = $promise->adoptedPromise;

        if ($syncPromise->state === SyncPromise::FULFILLED) {
            return $syncPromise->result;
        } else if ($syncPromise->state === SyncPromise::REJECTED) {
            throw $syncPromise->result;
        }

        throw new InvariantViolation("Could not resolve promise");
    }

So the whole queue must be progressed together. I guess you guys will have to write your own wait implementation to make it behave as expected.

Obviously, I am not 100% sure that this is enough to fix it (as I am not aware of DataLoader::await implementation details).

But let me know if I can make it easier for you somehow (e.g. by changing an interface of SyncPromiseAdapter or maybe changing how Executor calls wait).

[mcg-web]

Yes that where the bug is coming from, thank you. it works if we add the dataloader::await but only if we keep the wait of the override method

[mcg-web]

here a solution that works:

• we add two hooks to GraphQL lib

// src/Executor/Promise/Adapter/SyncPromiseAdapter.php

    /**
     * Synchronously wait when promise completes
     *
     * @param Promise $promise
     * @return mixed
     */
    public function wait(Promise $promise)
    {
        $this->beforeWait($promise);

        $dfdQueue = Deferred::getQueue();
        $promiseQueue = SyncPromise::getQueue();

        while (
            $promise->adoptedPromise->state === SyncPromise::PENDING &&
            !($dfdQueue->isEmpty() && $promiseQueue->isEmpty())
        ) {
            Deferred::runQueue();
            SyncPromise::runQueue();
            $this->onWait($promise);
        }

        /** @var SyncPromise $syncPromise */
        $syncPromise = $promise->adoptedPromise;

        if ($syncPromise->state === SyncPromise::FULFILLED) {
            return $syncPromise->result;
        } else if ($syncPromise->state === SyncPromise::REJECTED) {
            throw $syncPromise->result;
        }

        throw new InvariantViolation("Could not resolve promise");
    }

    /**
     * Execute just before starting to run promise completion
     *
     * @param Promise $promise
     */
    protected function beforeWait(Promise $promise)
    {
    }

    /**
     * While running promise completion
     *
     * @param Promise $promise
     */
    protected function onWait(Promise $promise)
    {
    }

• we modify DataLoader custom implementation to do the work

    protected function beforeWait(Promise $promise)
    {
        DataLoader::await();
    }

    protected function onWait(Promise $promise)
    {
        DataLoader::await();
    }

@vladar tell me what do you think of this solution please?

[vladar]

Works for me, pragmatically %) Can anyone prepare PR for this? I'll merge it.

[mcg-web]

I'll submit it, thank you @vladar ;)

[vladar]

Thanks! Merged and released 0.9.14

[mcg-web]

thanks again ;)

[mcg-web]

@n1ru4l new release here, also require to update graphql to 0.9.14 (graphql is not a requirement of the lib)...

[n1ru4l]

Thank you so much 😊 I will check that out on monday!

…

On Aug 18, 2017 7:23 PM, "Jeremiah VALERIE" ***@***.***> wrote: @n1ru4l <https://github.com/n1ru4l> new release here <https://github.com/overblog/dataloader-php/releases/tag/v0.5.2>, also require to update graphql to 0.9.14 (graphql is not a requirement of the lib)... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#150 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ANrH1_4Qa-8cXzOQLexbkYNfMnPmglLVks5sZciMgaJpZM4O6OO2> .

[vladar]

Closing this. Feel free to re-open if it is still broken.