Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract check for unique field names into separate rule #1111

Merged
merged 7 commits into from
May 2, 2022

Conversation

vhenzl
Copy link
Contributor

@vhenzl vhenzl commented Apr 18, 2022

Introduces UniqueFieldDefinitionNames validation rule.

Corresponding change in the reference implementation: graphql/graphql-js@6be63f0

Copy link
Collaborator

@spawnia spawnia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good overall

src/Validator/Rules/UniqueFieldDefinitionNames.php Outdated Show resolved Hide resolved
src/Validator/Rules/UniqueFieldDefinitionNames.php Outdated Show resolved Hide resolved
src/Validator/Rules/UniqueFieldDefinitionNames.php Outdated Show resolved Hide resolved
src/Validator/Rules/UniqueFieldDefinitionNames.php Outdated Show resolved Hide resolved
src/Validator/Rules/UniqueFieldDefinitionNames.php Outdated Show resolved Hide resolved
src/Validator/Rules/UniqueFieldDefinitionNames.php Outdated Show resolved Hide resolved
tests/Validator/UniqueFieldDefinitionNamesTest.php Outdated Show resolved Hide resolved
tests/Validator/UniqueFieldDefinitionNamesTest.php Outdated Show resolved Hide resolved
@vhenzl vhenzl marked this pull request as ready for review May 2, 2022 07:16
@spawnia spawnia merged commit d82cbaf into webonyx:master May 2, 2022
@vhenzl vhenzl deleted the rule-unique-field-definition-names branch May 2, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants