Never resolve additional types in Schema constructor #1137
Conversation
When you construct a Schema and pass an array of type callables like this:
```php
Schema(['types' => [
'TypeName' => function() { },
]);
```
the callables are immediately resolved in the constructor.
If you want the types to not be resolved, you must use a callable that returns the types array with callables like this:
```php
Schema(['types' => fn() => [
'TypeName' => function() { },
]);
```
I was surprised by that because I thought my array of callables was already enough for lazy loading.
When looking at the source code I find the distinction a bit weird and I think it can be handled in the same way.
When `Schema::getTypeMap` is called, it will call `Schema::collectAllTypes` which will call `Schema::resolveAdditionalTypes`.
|
I am trying to minimize type loading in #1104, perhaps you can base your pull request off of that. |
|
@spawnia Hmm, not really sure how. Maybe you can include this change in that PR when you finish it. |
|
Lazy loading of types is done differently, consider https://webonyx.github.io/graphql-php/schema-definition/#lazy-loading-of-types |
|
I need to register some types that are not referenced by other types, how is that possible without using the |
|
Can you illustrate why you would need many such types? If there is a small number of them, eager loading them should be no problem. Anyways, because |
When you construct a Schema and pass an array of type callables like this:
the callables are immediately resolved in the constructor.
If you want the types to not be resolved, you must use a callable that returns the types array with callables like this:
I was surprised by that because I thought my array of callables was already enough for lazy loading.
When looking at the source code I find the distinction a bit weird and I think it can be handled in the same way.
When
Schema::getTypeMapis called, it will callSchema::collectAllTypeswhich will callSchema::resolveAdditionalTypes.