Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option sortTypes to have SchemaPrinter order types alphabetically #1152

Merged
merged 5 commits into from
May 25, 2022

Conversation

ruudk
Copy link
Contributor

@ruudk ruudk commented May 25, 2022

This was removed in 9791dc1 but for some projects
it is useful to keep the schema sorted.

@ruudk ruudk force-pushed the sort-schema-in-printer branch from e4c1304 to cda0ec4 Compare May 25, 2022 07:34
This was removed in 9791dc1 but for some projects
it is useful to keep the schema sorted.
@ruudk ruudk force-pushed the sort-schema-in-printer branch from cda0ec4 to 00ed606 Compare May 25, 2022 07:35
@ruudk
Copy link
Contributor Author

ruudk commented May 25, 2022

Ready :)

@ruudk ruudk requested a review from spawnia May 25, 2022 07:40
@spawnia spawnia changed the title SchemaPrinter > Add sortTypes option - Add parseValue config option to InputObjectType to parse input value to custom value object May 25, 2022
@spawnia spawnia merged commit 339fd4d into webonyx:master May 25, 2022
@spawnia spawnia changed the title - Add parseValue config option to InputObjectType to parse input value to custom value object Add parseValue config option to InputObjectType to parse input value to custom value object May 25, 2022
@ruudk ruudk deleted the sort-schema-in-printer branch May 25, 2022 08:25
@spawnia spawnia changed the title Add parseValue config option to InputObjectType to parse input value to custom value object Add option sortTypes to have SchemaPrinter order types alphabetically May 25, 2022
@spawnia
Copy link
Collaborator

spawnia commented May 25, 2022

Oops, messed up the commit message. Thanks for the PR!

@ruudk
Copy link
Contributor Author

ruudk commented May 25, 2022

What happened here? A merge went wrong because the commit doesn't reflect what it did :)

@ruudk
Copy link
Contributor Author

ruudk commented May 25, 2022

Might be good to quickly fix with a force push 🙏

@spawnia
Copy link
Collaborator

spawnia commented May 25, 2022

Nah, I do not force push on master.

@spawnia
Copy link
Collaborator

spawnia commented May 25, 2022

I squashed the PR while merging, but added the wrong commit message - I copied the wrong line from resolving conflicts in the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants