fix(error): avoid phpunit crash by triggering side-effect via count on testcase #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I get it but… It just feels wrong from phpunit: they don't uphold the Then some other project also does this and we would add another exception case? I feel like we should re-open the phpunit issue, as I don't have the feeling this has been fully discussed. |
|
… and tests are failing anyway 😬 |
|
As I know Sebastian he won't discuss it anymore :D He does not want any 3rd party to mess with phpunit internals. Tests are fixed. |
spawnia
reviewed
Jun 17, 2024
Co-authored-by: Benedikt Franke <benedikt@franke.tech>
spawnia
reviewed
Jun 17, 2024
|
Thank you @simPod and @mfn! Released with https://github.com/webonyx/graphql-php/releases/tag/v15.12.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mfn this is a followup of sebastianbergmann/phpunit#5866 (comment)
What do you think about the fix? I don't see any other option since we analyze the whole stacktrace.