Serializes \UnitEnum and \BackedEnum in GraphQL\Type\Definition\EnumType when resolving return values from a Query or Mutation
#1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PhpEnumType` resolving return values from a Query or Mutation
Dahl99
changed the title
\UnitEnum and \BackedEnum in GraphQL\Type\Definition\PhpEnumType resolving return values from a Query or Mutation\UnitEnum and \BackedEnum in GraphQL\Type\Definition\PhpEnumType when resolving return values from a Query or Mutation
|
Have you seen #1604? |
Dahl99
changed the title
\UnitEnum and \BackedEnum in GraphQL\Type\Definition\PhpEnumType when resolving return values from a Query or Mutation\UnitEnum and \BackedEnum in GraphQL\Type\Definition\EnumType when resolving return values from a Query or Mutation
Yes, but returning a native PHP enum from a resolver with the schema first approach still fails. I've updated the tests to use SDL for creating the schema and they both fail without the changes to |
|
@spawnia mind having another look at this pull request? |
|
Released with https://github.com/webonyx/graphql-php/releases/tag/v15.14.0. Please consider sponsoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PHP has had native enums since version 8.1, there is an annoyance of not being able to return a native enum as a result from a query or mutation. If this is the case, it would have to be handled to return a string either by doing
MyEnum::A->nameorMyEnum::A->valuedepending on if it's a backed or unit enum.This is also a bit of a nuisance if one uses DTOs for returning the data, as the type would have to be a string instead of being an enum which mirrors the enum in the GraphQL schema.
This pull request should address these issues by serializing native PHP enums if they were to be returned from a query or mutation.