Drop scrutinizer checks as they're handled by PHPStan and code sniffer #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SGTM |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to jump before #569 because IMO this is easier to merge and addresses the issue partially. The concern expressed there about build failures on Scrutinizer seems 100% valid to me.
Builds often fail because of Scrutinizer reporting "new major severity issues introduction" even though PHPStan's smarter analysis is fine with the modified code. Eg. PHPStan can narrow the type based on PHPUnit assertion
self::assertInstanceOf(), Scrutinizer can not.Running CS check on Scrutinizer is pointless, we run it in Travis.