Skip to content

Switch to null-safe lazy initialization #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 21, 2020
Merged

Switch to null-safe lazy initialization #675

merged 13 commits into from
Jul 21, 2020

Conversation

@spawnia
Copy link
Collaborator

@spawnia spawnia commented Jun 16, 2020 •
edited
Loading

Let's continue the discussion we are having here: #557 (comment)

@simPod @shmax

@spawnia
Implement safe lazy initialization
fefabc2 
Let's continue the discussion we are having here: #557 (comment)
@spawnia spawnia requested a review from simPod June 16, 2020 19:57
@spawnia spawnia marked this pull request as draft June 16, 2020 19:58
@coveralls
Copy link

coveralls commented Jun 16, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.006%) to 86.247% when pulling 35b2929 on spawnia:safe-lazy-initialization into 154c37c on webonyx:master.

@spawnia spawnia marked this pull request as ready for review June 16, 2020 20:26
spawnia
spawnia commented Jun 16, 2020
View reviewed changes
spawnia added 4 commits June 22, 2020 12:11
@spawnia
Merge branch 'master' into safe-lazy-initialization
c09614b 
# Conflicts:
#	phpstan-baseline.neon
#	src/Error/Error.php
#	src/Type/Definition/ObjectType.php
#	src/Type/Schema.php
@spawnia
Typehint
2b548fc
@spawnia
Merge branch 'master' into safe-lazy-initialization
9fcfff6 
# Conflicts:
#	src/Type/Definition/InputObjectType.php
#	src/Type/Definition/UnionType.php
@spawnia
Fix codestyle
29c064d
shmax
shmax reviewed Jun 23, 2020
View reviewed changes
shmax
shmax reviewed Jun 23, 2020
View reviewed changes
shmax
shmax approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@shmax shmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I like that you knocked out a few stanning issues while you were at it.

@vladar
Copy link
Member

vladar commented Jul 21, 2020

LGTM 👍 Mind resolving conflicts? Will merge it then.

spawnia added 2 commits July 21, 2020 14:33
@spawnia
Merge branch 'master' into safe-lazy-initialization
556682f 
# Conflicts:
#	phpstan-baseline.neon
#	src/Error/Error.php
@spawnia
baseline
8109fb2
@spawnia
Copy link
Collaborator Author

spawnia commented Jul 21, 2020

@vladar ready to go.

@vladar vladar merged commit c1e9c5e into webonyx:master Jul 21, 2020
@spawnia spawnia deleted the safe-lazy-initialization branch July 21, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vladar vladar vladar left review comments

@simPod simPod Awaiting requested review from simPod

+1 more reviewer

@shmax shmax shmax approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@spawnia @coveralls @vladar @shmax