Extract check for unique type names into separate rule #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vhenzl
force-pushed
the
rule-unique-type-names
branch
from
c0bba97
to
4483f4c
Compare
vhenzl
force-pushed
the
rule-unique-type-names
branch
from
0e5308b
to
c4e4193
Compare
spawnia
requested changes
Feb 18, 2022
|
This should be good to go now. |
|
Nicely done, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
UniqueTypeNamesvalidation rule.Corresponding change in the reference implementation: graphql/graphql-js@257797a
Tests are failing because of #997.