Miscellaneous UI/config refactoring #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
throwaway96
force-pushed
the
refactoring-20240324
branch
from
fefc326
to
c2295d1
Compare
Centralize all information about configuration options in a single object. Replace hardcoded options UI with programmatic generation based on descriptions in config.js. Also throw exceptions on invalid config keys and stop changes to localConfig from affecting defaultConfig. Ideally the options UI would be entirely automatically generated, but a way a way to handle grouped options (like the SponsorBlock ones) is still needed. It is now easier to add a config option, and hopefully soon it will only require adding an entry to configOptions in config.js.
Provide a function for decoding rather than using raw character codes.
The new function is available globally as ytaf_showOptionsPanel() for console use.
throwaway96
force-pushed
the
refactoring-20240324
branch
from
c2295d1
to
a271695
Compare
mariotaku
approved these changes
Mar 27, 2024
throwaway96
added a commit
that referenced
this pull request
Mar 27, 2024
Miscellaneous UI/config refactoring Plus a last-minute fix for one of my mistakes
throwaway96
added a commit
that referenced
this pull request
Mar 27, 2024
Miscellaneous UI/config refactoring Plus a last-minute fix for one of my mistakes
throwaway96
added a commit
to throwaway96/youtube-webos
that referenced
this pull request
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config.js. This allowed me to replace the hardcoded options panel with a semi-automatically generated one. (There is not yet a way to specify that options are grouped, like the SponsorBlock sub-options are.) Now a config option can be added just by editing the data structure inconfig.jsand adding one line inui.js(which will hopefully no longer be necessary soon).localConfigno longer affectdefaultConfig.getKeyColor(evt.charCode), which will return e.g.'green'for code 404 (ornullif it's not a color button).ytaf_showOptionsPanel()for use via the console, which makes remote debugging much more convenient.I started calling the green button screen the "options panel" since
uiContainerisn't a very descriptive name. I'm open to other suggestions, though.