-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add webpack-defaults #35
refactor: add webpack-defaults #35
Conversation
Update README to use -loader suffix to support webpack 2
docs(LICENSE): add JSF License
docs(README): refactor for webpack v2
|
Ready to |
"prepublish": "yarn run build", | ||
"release": "yarn run standard-version", | ||
"security": "nsp check", | ||
"pretest": "yarn run build && node test/webpack.build.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's hold off until a decision on the Jest topic has been made before we land any conversions that negate all the Jest goodness.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep agreed, the loader works that was the baseline for the moment I will try to out a different approach later (it's 'planned' since a few days now:)) to start webpack in the test instead of making a 'test bundle'. Is there anything shipped already somewhere ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want a good example of where I want to go in the short term with testing, check the testing setup in the css-loader new-loader
branch. Snapshot testing is much like scoping commit messages, valuable where applicable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But in the new loader
branch, it doesn't 'run' through webpack atm and just loader.call({}, fixture)
etc. For coverage and 'basic' Input => Output testing this is totally fine, but when a loader relies on the Loader API at least one 'real world' scenario must be tested somehow :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hence the long term goal which will require a Jest preprocessor to handle the webpack magic portion while not compromising the Jest sugarness.
Fix
Test
Docs
Refactor
webpack-defaults
options.sourceMap
)TODO
schema-utils
(added but disabled atm)Fixes #14, #21, #31, #32, #33