Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add webpack-defaults #35

Closed
wants to merge 14 commits into from
Closed

refactor: add webpack-defaults #35

wants to merge 14 commits into from

Conversation

michael-ciniawsky
Copy link
Member

@michael-ciniawsky michael-ciniawsky commented Apr 18, 2017

Fix

  • Error Message

Test

  • Add Tests

Docs

  • Add LOADER.md (JSDoc)
  • Update README.md

Refactor

  • Add webpack-defaults
  • Support CoffeeScript v2
  • Load Sourcemaps only if setup (options.sourceMap)

TODO

  • add schema-utils (added but disabled atm)

Fixes #14, #21, #31, #32, #33

@michael-ciniawsky
Copy link
Member Author

michael-ciniawsky commented Apr 18, 2017

schema-utils could be patched later any time, the schema and logic is implemented, just need to shape schema-utils itself a bit, otherwise good to go for @beta meanwhile

@michael-ciniawsky michael-ciniawsky added this to the 1.0.0-beta milestone Apr 18, 2017
@michael-ciniawsky michael-ciniawsky requested review from bebraw, alexander-akait and joshwiens and removed request for bebraw and joshwiens May 2, 2017 10:49
@michael-ciniawsky
Copy link
Member Author

Ready to :shipit:

"prepublish": "yarn run build",
"release": "yarn run standard-version",
"security": "nsp check",
"pretest": "yarn run build && node test/webpack.build.js",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold off until a decision on the Jest topic has been made before we land any conversions that negate all the Jest goodness.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep agreed, the loader works that was the baseline for the moment I will try to out a different approach later (it's 'planned' since a few days now:)) to start webpack in the test instead of making a 'test bundle'. Is there anything shipped already somewhere ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want a good example of where I want to go in the short term with testing, check the testing setup in the css-loader new-loader branch. Snapshot testing is much like scoping commit messages, valuable where applicable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But in the new loader branch, it doesn't 'run' through webpack atm and just loader.call({}, fixture) etc. For coverage and 'basic' Input => Output testing this is totally fine, but when a loader relies on the Loader API at least one 'real world' scenario must be tested somehow :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hence the long term goal which will require a Jest preprocessor to handle the webpack magic portion while not compromising the Jest sugarness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants