Copy file permissions #316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 'copyPermissions: true' to the entry for the files to enable.
Just to be safe.
…-file-permissions Conflicts: README.md src/writeFile.js
|
|
alexander-akait
requested changes
Jan 24, 2019
There was a problem hiding this comment.
Thanks for PR, but it is invalid solution:
- It is doesn't work when you use memory fs
- It contains constants what doesn't work on windows
- We should use only
fsfromwebpack - Strange code with
devServer - No tests.
How it should be solved (exclude memory fs):
- We should implement
perrmissionsproperty inwebpack-sources(https://github.com/webpack/webpack-sources) - Write
permissionshere https://github.com/webpack/webpack/blob/master/lib/Compiler.js#L387 - Add here
permissionsproperty https://github.com/webpack-contrib/copy-webpack-plugin/blob/master/src/writeFile.js#L121
Maybe we can use mode name property to avoid misleading between node and our implementation
|
Thank you for including this feature., When do you think this will be merged? Is there any other options in the meanwhile? |
|
@anandbaskaran please read comment above |
|
This has drifted quite a bit since January and I don't think I will be able to make it correct + get the needed PRs into webpack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviving PR #119
Would resolve issue #35
This is updated to build against the latest master. Just as in the original PR I have not been able to add unit tests because I can't stat the emitted files.