-
-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Include the sourceMappingURL & sourceURL when toString() #417
feat: Include the sourceMappingURL & sourceURL when toString() #417
Conversation
202b58d
to
18a066e
Compare
@asnowwolf - Close & Open a new Pull Request. That should trigger the CLA system to send it again. |
Codecov Report
@@ Coverage Diff @@
## master #417 +/- ##
=========================================
+ Coverage 98.36% 98.4% +0.04%
=========================================
Files 9 9
Lines 306 314 +8
Branches 69 71 +2
=========================================
+ Hits 301 309 +8
Misses 5 5
Continue to review full report at Codecov.
|
I tried, but still no email sent to me... does the bot work properly? |
Could you please send me a CLA mail and I manually sign it? |
@asnowwolf Can you please try again the CLA Bot should work now 😛 |
@asnowwolf - You will need to close & reopen |
Is |
@ekulabuhov oh, yes, it is. I'll try to fix the documents too. |
45dfe63
to
4b9ac2e
Compare
Done. But my english is not so good, please review it and modify it freely. Thank you! |
If this PR is published to npm, please @ me here, some of other PRs are waiting for this one. |
This feature is useful when you need to pass the result of css-loader to angular: call to require('to-string-loader!css-loader? sourceMap!sass-loader?sourceMap!./ test.scss') will include source mapping, And finally assigned to the component's styles metadata
4b9ac2e
to
23eea3d
Compare
@michael-ciniawsky - This should be removed from the 1.0.0 milestone and published as a Updating to defaults will take some time, no reason to hold this feature up. |
Oh, so... a standalone loader, eg. https://github.com/asnowwolf/css-with-mapping-loader, is more preferred? |
@asnowwolf - No, that was just a comment on how we are going to release this to npm. The pull request will be accepted & released before the coming |
Oh, I see! |
@d3viant0ne Alright, yep the |
@asnowwolf Thx 😛 |
@asnowwolf Thank you! That's perfect 👍 |
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
yes
If relevant, did you update the README?
no
Summary
This feature is useful when you need to pass the result of css-loader to angular: call to require('to-string-loader!css-loader? sourceMap!sass-loader?sourceMap!./ test.scss') will include source mapping, And finally assigned to the component's styles metadata
Does this PR introduce a breaking change?
I think no, Unless some code assumes that the css content does not have source maps
Other information
It's useful to angular component style.