-
-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use absolute paths and remove sourceRoot when generating sourcemaps #430
Conversation
Codecov Report
@@ Coverage Diff @@
## master #430 +/- ##
==========================================
- Coverage 98.35% 98.32% -0.03%
==========================================
Files 9 9
Lines 304 299 -5
Branches 69 67 -2
==========================================
- Hits 299 294 -5
Misses 5 5
Continue to review full report at Codecov.
|
any updates ? |
@brokenmass for reference ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change appears to introduce some complexity for using, e.g., chrome dev tools. Because Additionally, without a protocol, Chrome treats the path as an absolute path after the host. So, on a Mac, it resolves to |
@jasisk - Can you get this into a new issue so we are sure this can be addressed one way or another |
Yep please open a new issues this is a very inconvenient regression to said it politely, we need to investigate in a clean way 😛 |
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Yes
If relevant, did you update the README?
Not relevant
Summary
Simplifies and correct sourcemaps generation by returning absolute sources paths and removing sourceRoot.
Fix #373 and #280
Does this PR introduce a breaking change?
No
Other information