Update README.md #473
Merged
Update README.md #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #473 +/- ##
======================================
Coverage 98.3% 98.3%
======================================
Files 10 10
Lines 354 354
Branches 79 79
======================================
Hits 348 348
Misses 6 6Continue to review full report at Codecov.
|
michael-ciniawsky
requested changes
Mar 31, 2017
README.md
Outdated
| @@ -205,8 +205,9 @@ You can configure the generated ident with the `localIdentName` query parameter | |||
| } | |||
| ``` | |||
|
|
|||
| You can also specify the absolute path to your custom `getLocalIdent` function to generate classname based on a different schema. Note that this requires `webpack >= v2.x.` since to be able to pass function in. For example: | |||
| You can also specify the absolute path to your custom `getLocalIdent` function to generate classname based on a different schema. This requires `webpack >= v2.x.` (it supports functions in the `options` object). For example: | |||
There was a problem hiding this comment.
webpack >= 2.x => webpack >= 2.2.1 bc before that version using functions in options would require to specify an identifier { loader: 'css-loader', options: { ident: 'css-loader', ...options } } to work properly
|
Review comment addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Docs
Did you add tests for your changes?
No
If relevant, did you update the README?
Yes
Summary
Previous wording was awkward, not sure the suggested one is perfect so you can reject this.
Does this PR introduce a breaking change?
No
Other information