Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve importLoaders section and example #512

Merged

Conversation

ndresx
Copy link
Contributor

@ndresx ndresx commented Apr 23, 2017

What kind of change does this PR introduce?
documentation improvement

If relevant, did you update the README?
This updates and hopefully improves the importLoaders section to get a better understanding of how the option works. See #510.

Does this PR introduce a breaking change?
No

@jsf-clabot
Copy link

jsf-clabot commented Apr 23, 2017

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@codecov
Copy link

codecov bot commented Apr 23, 2017

Codecov Report

Merging #512 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #512   +/-   ##
======================================
  Coverage    98.6%   98.6%           
======================================
  Files          10      10           
  Lines         359     359           
  Branches       81      81           
======================================
  Hits          354     354           
  Misses          5       5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fa64fd...9bcf0b7. Read the comment docs.

@michael-ciniawsky michael-ciniawsky self-assigned this Apr 23, 2017
@michael-ciniawsky michael-ciniawsky merged commit a5fdf84 into webpack-contrib:master Apr 23, 2017
fahad19 added a commit to fahad19/css-loader that referenced this pull request Apr 24, 2017
* master:
  fix: case insensitivity of @import (webpack-contrib#514)
  chore: update comment (webpack-contrib#515)
  docs(README): improve importLoaders section and example (webpack-contrib#512)
  docs(README): fix link (webpack-contrib#508)
  docs(README): fix typo in example (webpack-contrib#507)
  docs(README): fix typo in maintainers link (webpack-contrib#505)
  fix: imported variables are replaced in exports if followed by a comma (webpack-contrib#504)
  docs(README): standardize (webpack-contrib#503)
  test: `charset` directive (webpack-contrib#502)
  fix: url with a trailing space is now handled correctly (webpack-contrib#494)
  fix: use `btoa` instead `Buffer` (webpack-contrib#501)
  test: add test for escaped characters (webpack-contrib#493)
  test: add tests for encoded svg data uri (webpack-contrib#492)
  test: add tests when css contain data uri and source maps are enabled (webpack-contrib#491)
  fix: loader now correctly handles `url` with space(s) (webpack-contrib#495)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants