docs(README): add extract-loader example #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #518 +/- ##
======================================
Coverage 98.6% 98.6%
======================================
Files 10 10
Lines 359 359
Branches 81 81
======================================
Hits 354 354
Misses 5 5 |
michael-ciniawsky
requested changes
Apr 25, 2017
There was a problem hiding this comment.
@mareksuscak This is eventually is better placed in Examples #extract ? But it also has connections to toString() and Angular usage, so not 💯 where to place it at best tbh 😛
README.md
Outdated
| @@ -73,6 +73,10 @@ console.log(css); // {String} | |||
|
|
|||
| If there are SourceMaps, they will also be included in the result string. | |||
|
|
|||
| If, for one reason or another, you need to extract CSS as a | |||
| plain string resource (i.e. not wrapped in a JS module) you | |||
| might want to check out the [extract-loader](https://github.com/peerigon/extract-loader). It's useful when you, for instance, need to post-process the CSS as a string. | |||
There was a problem hiding this comment.
\n after the extract-loader link aswell for consistency? [link].\n It ....
post-process => post process
There was a problem hiding this comment.
An small setup example would be appreciated aswell :)
There was a problem hiding this comment.
cool will do, thanks for reviewing!
michael-ciniawsky
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently needed this and I think it’s worth documenting for other folks. Took me a few days to figure out.
The difference between to-string-loader and extract-loader is that former wraps the CSS in a JS module while latter executes the css-loader’s output at compile time and passes that to the next loader in the chain. Came in handy when we needed some further post processing.