Skip to content

docs(README): Fix ExtractTextPlugin example #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2017

Conversation

charlesponti
Copy link
Contributor

@charlesponti charlesponti commented Aug 11, 2017

What kind of change does this PR introduce?

This is a fix for the docs

Did you add tests for your changes?

There aren't any relevant tests for the README :)

If relevant, did you update the README?

I have updated the README.

Summary

There was an extra ] in the example

Does this PR introduce a breaking change?

This PR does not introduce a breaking change

Other information

There was an extra `]` in the example
@jsf-clabot
Copy link

jsf-clabot commented Aug 11, 2017

CLA assistant check
All committers have signed the CLA.

@joshwiens joshwiens changed the title fix(README): Fix issue in ExtractTextPlugin example docs(README): Fix issue in ExtractTextPlugin example Aug 11, 2017
@joshwiens
Copy link
Member

@charlesponti - You will have to sign the CLA ( click the button ) before I can merge this :)

@michael-ciniawsky michael-ciniawsky changed the title docs(README): Fix issue in ExtractTextPlugin example docs(README): Fix ExtractTextPlugin example Aug 11, 2017
Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charlesponti
Copy link
Contributor Author

@michael-ciniawsky @d3viant0ne CLA signed 👍 Thanks

@joshwiens joshwiens merged commit b92c941 into webpack-contrib:master Aug 13, 2017
@michael-ciniawsky michael-ciniawsky modified the milestone: 0.28.6 Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants