Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: converting reserved and control filesystem characters to - #972

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #967

Breaking Changes

Potentially yes, but it is big regression for 3.0.0 version so it is marked as bug.

Additional Info

No

@alexander-akait alexander-akait force-pushed the fix-converting-filesystem-characters-to-`-` branch from a08de15 to eca072e Compare July 17, 2019 20:14
@alexander-akait alexander-akait merged commit f51859b into master Jul 17, 2019
@alexander-akait alexander-akait deleted the fix-converting-filesystem-characters-to-`-` branch July 17, 2019 20:22
@codecov
Copy link

codecov bot commented Jul 18, 2019

Codecov Report

Merging #972 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #972      +/-   ##
==========================================
+ Coverage   98.33%   98.34%   +0.01%     
==========================================
  Files          10       10              
  Lines         421      424       +3     
  Branches      126      126              
==========================================
+ Hits          414      417       +3     
  Misses          7        7
Impacted Files Coverage Δ
src/utils.js 99.35% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65e4fc0...eca072e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Behaviour of the "[path]" placeholder have been changed in a refactor commit
1 participant