Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: minimum supported Node.js version is 18.12.0 #252

Merged
merged 6 commits into from
Jan 17, 2024

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Jan 14, 2024

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Update Node & deps.

Breaking Changes

Minimum supported Node.js version is 18.12.0

Additional Info

No

Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (96a5625) 96.09% compared to head (1569133) 96.09%.

Files Patch % Lines
src/index.js 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #252   +/-   ##
=======================================
  Coverage   96.09%   96.09%           
=======================================
  Files           3        3           
  Lines         282      282           
  Branches      111      111           
=======================================
  Hits          271      271           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@snitin315 snitin315 marked this pull request as ready for review January 16, 2024 05:04
package.json Outdated
"@types/serialize-javascript": "^5.0.4",
"@webpack-contrib/eslint-config-webpack": "^3.0.0",
"babel-jest": "^29.7.0",
"clean-css": "^5.3.3",
"copy-webpack-plugin": "^9.1.0",
"copy-webpack-plugin": "^12.0.1",
Copy link
Member

@alexander-akait alexander-akait Jan 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't update it right now due a bug on Node.js@18 side, it was fixed in 20.x and 21.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants