This repository has been archived by the owner on May 29, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 513
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(extract): return an array of loader objects (#343)
* Return an array of loader objects from extract() From tmair@1414036 * Add unit tests for ExtractTextPlugin.extract() Use "options" for own loader options Also use "options" as a check for loader being specified as a loader object
- Loading branch information
Showing
2 changed files
with
152 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,144 @@ | ||
var should = require("should"); | ||
var ExtractTextPlugin = require("../"); | ||
|
||
var loaderPath = require.resolve("../loader.js"); | ||
|
||
describe("ExtractTextPlugin.extract()", function() { | ||
it("throws if given multiple arguments", function() { | ||
should.throws(function() { | ||
ExtractTextPlugin.extract("style-loader", "css-loader"); | ||
}); | ||
}); | ||
|
||
context("specifying loader", function() { | ||
it("accepts a loader string", function() { | ||
ExtractTextPlugin.extract("css-loader").should.deepEqual([ | ||
{ loader: loaderPath, options: { omit: 0, remove:true } }, | ||
{ loader: "css-loader" } | ||
]); | ||
}); | ||
|
||
it("accepts a chained loader string", function() { | ||
ExtractTextPlugin.extract( | ||
"css-loader!postcss-loader!sass-loader" | ||
).should.deepEqual([ | ||
{ loader: loaderPath, options: { omit: 0, remove:true } }, | ||
{ loader: "css-loader" }, | ||
{ loader: "postcss-loader" }, | ||
{ loader: "sass-loader" } | ||
]); | ||
}); | ||
|
||
it("accepts an array of loader names", function() { | ||
ExtractTextPlugin.extract( | ||
["css-loader", "postcss-loader", "sass-loader"] | ||
).should.deepEqual([ | ||
{ loader: loaderPath, options: { omit: 0, remove:true } }, | ||
{ loader: "css-loader" }, | ||
{ loader: "postcss-loader" }, | ||
{ loader: "sass-loader" } | ||
]); | ||
}); | ||
|
||
it("accepts a loader object", function() { | ||
ExtractTextPlugin.extract({ loader: "css-loader" }).should.deepEqual([ | ||
{ loader: loaderPath, options: { omit: 0, remove:true } }, | ||
{ loader: "css-loader" } | ||
]); | ||
}); | ||
|
||
it("accepts a loader object with an options object", function() { | ||
ExtractTextPlugin.extract( | ||
{ loader: "css-loader", options: { modules: true } } | ||
).should.deepEqual([ | ||
{ loader: loaderPath, options: { omit: 0, remove:true } }, | ||
{ loader: "css-loader", options: { modules: true } } | ||
]); | ||
}); | ||
|
||
it("accepts a loader object with a (legacy) query object", function() { | ||
ExtractTextPlugin.extract( | ||
{ loader: "css-loader", query: { modules: true } } | ||
).should.deepEqual([ | ||
{ loader: loaderPath, options: { omit: 0, remove:true } }, | ||
{ loader: "css-loader", query: { modules: true } } | ||
]); | ||
}); | ||
|
||
it("accepts an array of loader objects", function() { | ||
ExtractTextPlugin.extract([ | ||
{ loader: "css-loader" }, | ||
{ loader: "postcss-loader" }, | ||
{ loader: "sass-loader" } | ||
]).should.deepEqual([ | ||
{ loader: loaderPath, options: { omit: 0, remove:true } }, | ||
{ loader: "css-loader" }, | ||
{ loader: "postcss-loader" }, | ||
{ loader: "sass-loader" } | ||
]); | ||
}); | ||
}) | ||
|
||
context("specifying fallbackLoader", function() { | ||
it("accepts a fallbackLoader string", function() { | ||
ExtractTextPlugin.extract({ | ||
fallbackLoader: "style-loader", | ||
loader: "css-loader" | ||
}).should.deepEqual([ | ||
{ loader: loaderPath, options: { omit: 1, remove: true } }, | ||
{ loader: "style-loader" }, | ||
{ loader: "css-loader" } | ||
]); | ||
}); | ||
|
||
it("accepts a chained fallbackLoader string", function() { | ||
ExtractTextPlugin.extract({ | ||
fallbackLoader: "something-loader!style-loader", | ||
loader: "css-loader" | ||
}).should.deepEqual([ | ||
{ loader: loaderPath, options: { omit: 2, remove: true } }, | ||
{ loader: "something-loader" }, | ||
{ loader: "style-loader" }, | ||
{ loader: "css-loader" } | ||
]); | ||
}); | ||
|
||
it("accepts a fallbackLoader object", function() { | ||
ExtractTextPlugin.extract({ | ||
fallbackLoader: { loader: "style-loader" }, | ||
loader: "css-loader" | ||
}).should.deepEqual([ | ||
{ loader: loaderPath, options: { omit: 1, remove: true } }, | ||
{ loader: "style-loader" }, | ||
{ loader: "css-loader" } | ||
]); | ||
}); | ||
|
||
it("accepts an array of fallbackLoader objects", function() { | ||
ExtractTextPlugin.extract({ | ||
fallbackLoader: [ | ||
{ loader: "something-loader" }, | ||
{ loader: "style-loader" } | ||
], | ||
loader: "css-loader" | ||
}).should.deepEqual([ | ||
{ loader: loaderPath, options: { omit: 2, remove: true } }, | ||
{ loader: "something-loader" }, | ||
{ loader: "style-loader" }, | ||
{ loader: "css-loader" } | ||
]); | ||
}); | ||
}); | ||
|
||
it("passes additional options to its own loader", function() { | ||
ExtractTextPlugin.extract({ | ||
fallbackLoader: "style-loader", | ||
loader: "css-loader", | ||
publicPath: "/test" | ||
}).should.deepEqual([ | ||
{ loader: loaderPath, options: { omit: 1, remove: true, publicPath: "/test" } }, | ||
{ loader: "style-loader" }, | ||
{ loader: "css-loader" } | ||
]); | ||
}); | ||
}); |