Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Commit

Permalink
Add webpack 2 RC compatibility
Browse files Browse the repository at this point in the history
  • Loading branch information
SpaceK33z authored Dec 29, 2016
1 parent 480a7cb commit cbd4690
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"author": "Tobias Koppers @sokra",
"description": "Extract text from bundle into a file.",
"peerDependencies": {
"webpack": "^2.1.0-beta.19"
"webpack": "^2.1.0-beta.19 || ^2.2.0-rc.0"
},
"dependencies": {
"async": "^2.1.2",
Expand Down

13 comments on commit cbd4690

@willhoney7
Copy link

@willhoney7 willhoney7 commented on cbd4690 Dec 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay! I hope this will be made into 2.0.0-beta.5 soon.

thanks!

@graingert
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SpaceK33z do you know when this will get a release?

@SpaceK33z
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@graingert don't know, I don't have npm publish permissions

@catamphetamine
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When will beta-5 be released then

@graingert
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sokra can we get a release on this. Maybe an rc too?

@vlio20
Copy link

@vlio20 vlio20 commented on cbd4690 Jan 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super cool! waiting for the release, till then my shrinkwrap is broken :(

@jesperronn
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found this most fantastic workaround until a release is pushed:

npm install --save-dev webpack/extract-text-webpack-plugin#cbd4690

@benvinegar
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sokra @TheLarkInn – any chance we can publish a new version, e.g. beta5? Having to point to this SHA instead of using a proper npm version is causing us serious grief at @getsentry, where we're trying to use Webpack 2 rc3 live.

@catamphetamine
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's really not a healthy situation when a PR merger doesn't have rights to publish a fix and the project owner just ignores the project.

@graingert
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SpaceK33z can you publish to another npm package?

@catamphetamine
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@graingert lol, hold your horses, young man.
when @sokra comes out of his ivory tower he'll publish this thing, no doubts.
probably so busy landing that 2.2.0 release.
I'm sure his email is disabled otherwise he'd get hundreds of github notifications per day.

@TheLarkInn
Copy link

@TheLarkInn TheLarkInn commented on cbd4690 Jan 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@halt-hammerzeit @benvinegar @graingert Hey sorry! Everyone has different availabilities (which means we are all not around just yet) and as a team we have to ensure there isn't any other critical low hanging fruit before we publish. I'm actively on this ensuring we will get you these changes.

I really appreciate your patience and kindness in the matter.

@graingert
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@halt-hammerzeit @benvinegar @TheLarkInn ah it looks like v2.0.0-beta.5 is out

Please sign in to comment.