-
Notifications
You must be signed in to change notification settings - Fork 513
The Future of this Plugin vs. Mini CSS Extract Plugin (=> Use Mini CSS Extract Plugin) #749
Comments
@garygreen here, some problems very difficult to fix and somebody of us don't have many time. P.S. I can take care about this only through 2 week. |
It doesn't make sense to contribute to a plugin which, by the sounds of it, is becoming redundant? If the official aim is to have css extraction built into Webpack thru the Mini Extract plugin, should support for Webpack 4 not be phased out of ETWP? If this was official, it would clear up all the Webpack 4 issues in this repository and also create a clear direction for where things should be heading. |
@garygreen plugin just don't support |
Anyway we are open for PR to support |
I wasn't suggesting dropping support for webpack@3, of course it's still will be supported.
This is giving mixed signals. You either should 1) move in a direction to support Mini Css Extract, or 2) work alongside it and dilute the community/development of both plugins. Option 2 is one you are suggesting, and it's not a good one, IMO. These are steps I believe would help move things in the right direction:
|
@garygreen proposed solution sounds very reasonable, switched to |
TL;DR Use The |
I leave this issue open for visibility until I have the chance to |
For the most of cases use Well, I pretty disappointed. Can't you just put ETWP to work with Maybe the biggest arch issue which need to be solved is to accept the webpack's breaking change nature and transform ETWP in a set of tools not coupled webpack specific arch version but one which can be applied to any of it. How about it? ps.: Please, don't get me wrong, I'm not meaning that the problem you guys are trying to solve is a simple/easy thing. |
@dfleury just stick with webpack 3 until you feel comfortable of letting go of ETWP. Basically ETWP has always managed to get around by using hacks, upgrading it properly to work with the new APIs in webpack 4 basically means rewriting it as MiniCSSExtractPlugin. Everyone have limited time and effort, its better to redirect the energy on building stable future proof solutions rather than putting a lot of time and effort maintaining the past. |
@dfleury main problem in extract - difference type of assets ( |
According to the TL;DR of the comment below, mini-css-extract-plugin is replacing extract-text-webpack-plugin which will be deprecated. Since this does not have a built in optimizer for CSS, a separate plugin is used. However overriding the optimizer means that UglifyJS must be included manually (previously this was a transitive dependency of webpack which was used automatically in production mode) webpack-contrib/extract-text-webpack-plugin#749 (comment) This closes phoenixframework#2818
According to the TL;DR of the comment below, mini-css-extract-plugin is replacing extract-text-webpack-plugin which will be deprecated. Since this does not have a built in optimizer for CSS, a separate plugin is used. However overriding the optimizer means that UglifyJS must be included manually (previously this was a transitive dependency of webpack which was used automatically in production mode) webpack-contrib/extract-text-webpack-plugin#749 (comment) This closes phoenixframework#2818
According to the TL;DR of the comment below, mini-css-extract-plugin is replacing extract-text-webpack-plugin which will be deprecated. Since this does not have a built in optimizer for CSS, a separate plugin is used. However overriding the optimizer means that UglifyJS must be included manually (previously this was a transitive dependency of webpack which was used automatically in production mode) webpack-contrib/extract-text-webpack-plugin#749 (comment) This closes #2818
DEPRECATED |
The last release was nearly a month ago.
Could we have some official responses and guidance from the maintainers please.
The text was updated successfully, but these errors were encountered: