This repository has been archived by the owner on May 29, 2019. It is now read-only.
allow both loader.options and loader.query, add test cases
#276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Webpack v2 recommends using the `options` key instead of `query`: https://webpack.js.org/configuration/module/#useentry
|
LGTM. I think that Node 0.12 check can be discarded given webpack 2 is Node 4+ now. |
|
@dlindenkreuz - This should no longer be an issue as of https://github.com/webpack-contrib/extract-text-webpack-plugin/releases/tag/v2.0.0-rc.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webpack v2 recommends using the
optionskey instead ofquery: https://webpack.js.org/configuration/module/#useentrySee also: b79da9f#commitcomment-19621830