Updates for v2

[michael-ciniawsky]

• Update README.md
• Update CI (travis.yml)
• Add Engines (package.json)
• Update Dependencies (package.json)
• Update PeerDependency webpack v2.2.0-beta.19 || 2.2.0-rc.0 => 2.2.0
• Add Logo* (Discussion required, gh-pages needs to be enabled for this repo)
• Add LICENSE (JS Foundation [taken from css-loader😛])
• Add .github(ISSUE && PULL_REQUEST)
• Add JSDOC

Fixes PR's:

#123
#146
#147
#265
#312
#347

@webpack/core-team

[codecov-io]

Current coverage is 86.14% (diff: 100%)

Merging #349 into master will not change coverage

@@             master       #349   diff @@
==========================================
  Files             4          4          
  Lines           332        332          
  Methods          68         68          
  Messages          0          0          
  Branches         71         71          
==========================================
  Hits            286        286          
  Misses           46         46          
  Partials          0          0          

Powered by Codecov. Last update c8494f3...e55cf60

[TheLarkInn]

Looking good so far

[michael-ciniawsky]

README needs overhaul for final v2 syntax changes, when the respective PR's got merged

[michael-ciniawsky]

@webpack/core-team Are you guys in general open to share maintenance burden for this repo if we find a few devs open to help out ? I wouldn't be able to do it alone atm8, but open to search for folks and go 'deeper' 😛

[michael-ciniawsky]

Are there any official ISSUE && PULL_REQUEST_TEMPLATES for webpack plugins ?

[bebraw]

Are you guys in general open to share maintenance burden for this repo if we find a few devs open to help out ? I wouldn't be able to do it alone atm8, but open to search for folks and go 'deeper' 😛

Yup. We'll arrange a little meeting on Wednesday on this. Let's coordinate this at Slack.

Are there any official ISSUE && PULL_REQUEST_TEMPLATES for webpack plugins ?

The core repository has something, but I expect that needs to be tweaked and simplified a ton.

[michael-ciniawsky]

Yup. We'll arrange a little meeting on Wednesday on this. Let's coordinate this at Slack.

👍

The core repository has something, but I expect that needs to be tweaked and simplified a ton.

Ok I derivate from core, and changes are proposed for discussion

[phun-ky]

When can this be out? webpack 2 is pretty much useless without this plugin <3

(Just to be clear, I've tried the beta version with webpack 2.2, and this plugin is currently not working as intended. I've met the new config according to the docs, no produced css)

[michael-ciniawsky]

@phun-kyThe syntax changes are in #343, could you try this branch please ? The README is sill WIP until #343 is landing, working and tested... :D.

[joshwiens]

This should be limited to master only

branches:
only:
- master

[joshwiens]

If you are going to validate against multiple version, you should do it in a matrix and use the whole JOB_PART setup from webpack/webpack.

Right now if you add more validation tasks ( and they are coming ) they will execute against every version which is unnecessary & inconsiderate to Travis who is running all this for free :)

[michael-ciniawsky]

@d3viant0ne Would you be so kind to help me with the correct setup please? :)

[joshwiens]

.travis.yml

sudo: false
language: node_js
branches:
  only:
    - v2
matrix:
  fast_finish: true
  include:
    - os: linux
      node_js: "7"
      env: WEBPACK_VERSION="2.2.0" JOB_PART=lint
    - os: linux
      node_js: "6"
      env: WEBPACK_VERSION="2.2.0" JOB_PART=test
    - os: linux
      node_js: "4.3"
      env: WEBPACK_VERSION="2.2.0" JOB_PART=test
    - os: linux
      node_js: "7"
      env: WEBPACK_VERSION="2.2.0" JOB_PART=test
before_install:
  - nvm --version
  - node --version
  - npm --version
before_script:
  - 'if [ "$WEBPACK_VERSION" ]; then npm install webpack@^$WEBPACK_VERSION; fi'
script:
  - npm run travis:$JOB_PART
after_success:
  - bash <(curl -s https://codecov.io/bash)

package.json

    "travis:test": "npm run test",
    "travis:lint": "npm run lint",

[joshwiens]

If you need to validate against Webpack 1.14.x add ...

    - os: linux
      node_js: "4.3"
      env: WEBPACK_VERSION="1.14.0" JOB_PART=test

[michael-ciniawsky]

@d3viant0ne Thx I will update asap 🚀 , webpack v1 is unnecessary, since v2 introduces breaking changes incompatible with v1 (to my knowledge 😛 )

[phun-ky]

@michael-ciniawsky the odd thing is that it works in development, I think it's because of this plugin:

new WriteFilePlugin({
  // Write only files that have '.css' extension.
  test: /\.css$/,
  useHashIndex: true
}),

That forces a file write of the css file.

(I am aware of this is a PR, if this could be an issue, just say so, and I will make an issue for this, sorry for the OT)

[michael-ciniawsky]

@phun-ky WriteFilePlugin is for webpack-dev-server if you want the file being written to disk and serve them as <link> instead of including them in the bundle. There seems to be an issue with this plugin and webpack[-dev-server] 2 aswell #30. Without WriteFilePlugin does it basically work ? I will ask in the slack channel if WriteFilePlugin + ExtractTextPlugin have conflicts in general or if not how to use them in conjunction.

[bebraw]

This should link to dev docs or a similar resource.

[michael-ciniawsky]

Yep, but we don’t have any dev docs atm, I will update as soon as we got them 😛