Fix schema #372

bebraw · 2017-01-28T16:32:41Z

Made sure proper error messages are emitted on failure
Expanded schema to include omit/remove

Closes #371.

codecov-io · 2017-01-28T16:35:14Z

Current coverage is 87.06% (diff: 100%)

Merging #372 into master will increase coverage by 0.03%

@@             master       #372   diff @@
==========================================
  Files             5          5          
  Lines           347        348     +1   
  Methods          70         70          
  Messages          0          0          
  Branches         71         71          
==========================================
+ Hits            302        303     +1   
  Misses           45         45          
  Partials          0          0

Powered by Codecov. Last update c565a5d...b3339b9

Related to webpack-contrib#371.

Closes webpack-contrib#371.

Now you can see which field caused the error.

bebraw added this to the 2.0 final milestone Jan 28, 2017

bebraw requested a review from joshwiens January 28, 2017 16:32

bebraw mentioned this pull request Jan 28, 2017

rc.1 breaks when remove: false, property is set with Error: No errors message #371

Closed

bebraw added 2 commits January 28, 2017 19:08

fix(schema) - Emit proper error messages

15bea45

Related to webpack-contrib#371.

fix(schema) - Allow extract to accept omit/remove flags

306c624

Closes webpack-contrib#371.

bebraw force-pushed the fix-schema branch from 350a55f to 6f0d235 Compare January 28, 2017 17:08

fix(schema) - Connect loader schema with the code properly

267a54f

bebraw force-pushed the fix-schema branch from 6f0d235 to 267a54f Compare January 28, 2017 17:11

joshwiens approved these changes Jan 28, 2017

View reviewed changes

feat - Show nicer errors if there are extra fields

b3339b9

Now you can see which field caused the error.

bebraw force-pushed the fix-schema branch from 197ab81 to b3339b9 Compare January 28, 2017 17:34

bebraw merged commit e11b322 into webpack-contrib:master Jan 28, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix schema #372

Fix schema #372

bebraw commented Jan 28, 2017

codecov-io commented Jan 28, 2017 •

edited

Loading

Fix schema #372

Fix schema #372

Conversation

bebraw commented Jan 28, 2017

codecov-io commented Jan 28, 2017 • edited Loading

Current coverage is 87.06% (diff: 100%)

codecov-io commented Jan 28, 2017 •

edited

Loading