Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Update README.md to reflect version changes #432

Merged
merged 1 commit into from
Feb 25, 2017

Conversation

candu
Copy link
Contributor

@candu candu commented Feb 24, 2017

These instructions are outdated as of the 2.0.0 release, published to npm a couple of hours before this pull request was submitted.

Without these changes, following the directions for installation alongside webpack 1 results in an "unmet peer dependency" error.

@jsf-clabot
Copy link

jsf-clabot commented Feb 24, 2017

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Feb 24, 2017

Codecov Report

Merging #432 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #432   +/-   ##
=======================================
  Coverage   90.25%   90.25%           
=======================================
  Files           6        6           
  Lines         359      359           
  Branches       76       76           
=======================================
  Hits          324      324           
  Misses         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5268d14...290bb91. Read the comment docs.

@joshwiens
Copy link
Member

Thanks @candu - Please sign the CLA and i'll get this merged.

@candu
Copy link
Contributor Author

candu commented Feb 24, 2017

Just signed it, though it isn't showing up on the automatic check dashboard above.

@joshwiens
Copy link
Member

Usually a sign of your local git config email not matching that which resides in your github account.

@candu
Copy link
Contributor Author

candu commented Feb 24, 2017

I tried revoking CLA access, adding the email address in question to my github account, setting it as my primary, and re-signing. No dice; it insists on auto-filling my old email address.

Is there an easier way to remedy this? I'm happy to sign the CLA, but it isn't making this easy for me, and I don't have loads of time in the middle of a workday to debug further.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants