Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the cache default functions gets correctly executed #150

Merged
merged 1 commit into from
Jul 11, 2017

Conversation

danez
Copy link
Collaborator

@danez danez commented Jul 11, 2017

Q A
Bug fix? yes
Breaking change? no
New feature? no
Deprecations? no
Tests added? yes
Docs updated? no
Fixed tickets Fixes #147
License MIT

@codecov
Copy link

codecov bot commented Jul 11, 2017

Codecov Report

Merging #150 into master will increase coverage by 1.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
+ Coverage   66.02%   67.24%   +1.22%     
==========================================
  Files           8        8              
  Lines         209      229      +20     
  Branches       52       68      +16     
==========================================
+ Hits          138      154      +16     
- Misses         58       64       +6     
+ Partials       13       11       -2
Impacted Files Coverage Δ
src/options/WebpackOptionHelper.js 100% <100%> (ø) ⬆️
tasks/webpack-dev-server.js 13.46% <0%> (-1.44%) ⬇️
tasks/webpack.js 83.92% <0%> (+7.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96fa0ef...be9a75b. Read the comment docs.

@danez danez merged commit d01aba9 into master Jul 11, 2017
@danez danez deleted the fix-cache branch July 11, 2017 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpack 3 fails on watch with cache being a function
1 participant