feat: adding "scriptingEnabled" option to source set #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added option "scriptingEnabled" for "source" object, affected src/utils.js; - added description and example of using "scriptingEnabled" option in README.md; - improved plugin: src/plugins/sources-plugin.js; - extended options structure: src/options.json; - extended test: test/sources-option.test.js; - extended test: test/validate-options.test.js; - added image: test/fixtures/noscript.png; - extended content: test/fixtures/simple.html; - snapshots generated, tests passed.
|
|
Closed
alexander-akait
approved these changes
Jul 10, 2022
Codecov Report
@@ Coverage Diff @@
## master #448 +/- ##
==========================================
+ Coverage 92.17% 92.20% +0.02%
==========================================
Files 7 7
Lines 588 590 +2
Branches 188 190 +2
==========================================
+ Hits 542 544 +2
Misses 37 37
Partials 9 9
Continue to review full report at Codecov.
|
|
Thank you |
|
@alexander-akait Thank you for your cooperation! Glad to help your project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is an improvement and solution for the problem:
Issue 446
Changes:
This PR contains a:
Motivation / Use-Case
Breaking Changes
Additional Info