Skip to content

Commit

Permalink
chore: add webpack v5 support, run webpack-defaults (#317)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: minimum supported Node.js verison is `10.13`, minimum support webpack version is `4`
  • Loading branch information
Ryan Clark authored Mar 13, 2020
1 parent e2c02ac commit f0b42b4
Show file tree
Hide file tree
Showing 19 changed files with 3,935 additions and 1,835 deletions.
1 change: 0 additions & 1 deletion .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,4 @@ insert_final_newline = true
trim_trailing_whitespace = true

[*.md]
insert_final_newline = true
trim_trailing_whitespace = false
5 changes: 4 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
package-lock.json
/coverage
/dist
/node_modules
/test/fixtures
6 changes: 1 addition & 5 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
module.exports = {
root: true,
plugins: ['prettier'],
extends: ['@webpack-contrib/eslint-config-webpack'],
rules: {
'prettier/prettier': ['error'],
},
extends: ['@webpack-contrib/eslint-config-webpack', 'prettier'],
};
12 changes: 10 additions & 2 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -140,13 +140,21 @@ module. Thankfully, Github provides a means to do this. Add a dependency to the
```json
{
"devDependencies": {
"${package}": "webpack-contrib/${package}#{id}/head"
"less-loader": "webpack-contrib/less-loader#{id}/head"
}
}
```

Where `{id}` is the # ID of your Pull Request.

## Contributor License Agreement

When submitting your contribution, a CLA (Contributor License Agreement) bot will come by to verify that you signed the [CLA](https://cla.js.foundation/webpack-contrib/less-loader).
If it is your first time, it will link you to the right place to sign it.
However, if you have committed your contributions using an email that is not the same as your email used on GitHub, the CLA bot can't accept your contribution.

Run `git config user.email` to see your Git email, and verify it with [your GitHub email](https://github.com/settings/emails).

## Thanks

For your interest, time, understanding, and for following this simple guide.
For your interest, time, understanding, and for following this simple guide.
1 change: 1 addition & 0 deletions .github/FUNDING.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
open_collective: webpack
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@
existing template types, your issue may be closed as invalid. Our issue
templates contain fields that help us help you, and without that important
info, we might as well be ice-skating uphill, carrying a wooly mammoth.
-->
-->
21 changes: 10 additions & 11 deletions .github/ISSUE_TEMPLATE/BUG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
---
name: 🐛 Bug Report
about: Something went awry and you'd like to tell us about it.

---

<!--
Expand All @@ -15,11 +14,11 @@ about: Something went awry and you'd like to tell us about it.
Head to StackOverflow or https://gitter.im/webpack/webpack.
-->

* Operating System:
* Node Version:
* NPM Version:
* webpack Version:
* less-loader Version:
- Operating System:
- Node Version:
- NPM Version:
- webpack Version:
- less-loader Version:

### Expected Behavior

Expand All @@ -32,13 +31,13 @@ about: Something went awry and you'd like to tell us about it.
### Code

```js
// webpack.config.js
// If your code blocks are over 20 lines, please paste a link to a gist
// (https://gist.github.com).
// webpack.config.js
// If your code blocks are over 20 lines, please paste a link to a gist
// (https://gist.github.com).
```

```js
// additional code, HEY YO remove this block if you don't need it
// additional code, HEY YO remove this block if you don't need it
```

### How Do We Reproduce?
Expand All @@ -48,4 +47,4 @@ about: Something went awry and you'd like to tell us about it.
If your webpack config is over 50 lines long, please provide a URL to a repo
for your beefy 🍖 app that we can use to reproduce.
-->
-->
4 changes: 1 addition & 3 deletions .github/ISSUE_TEMPLATE/DOCS.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
---
name: 📚 Documentation
about: Are the docs lacking or missing something? Do they need some new 🔥 hotness? Tell us here.

---

<!--
Expand All @@ -26,5 +25,4 @@ Documentation Is:

### Please Explain in Detail...


### Your Proposal for Changes
### Your Proposal for Changes
15 changes: 6 additions & 9 deletions .github/ISSUE_TEMPLATE/FEATURE.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
---
name: ✨ Feature Request
about: Suggest an idea for this project

---

<!--
Expand All @@ -15,14 +14,12 @@ about: Suggest an idea for this project
Head to StackOverflow or https://gitter.im/webpack/webpack.
-->

* Operating System:
* Node Version:
* NPM Version:
* webpack Version:
* less-loader Version:
- Operating System:
- Node Version:
- NPM Version:
- webpack Version:
- less-loader Version:

### Feature Proposal



### Feature Use Case
### Feature Use Case
18 changes: 6 additions & 12 deletions .github/ISSUE_TEMPLATE/MODIFICATION.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
---
name: 🔧 Modification Request
about: Would you like something work differently? Have an alternative approach? This is the template for you.

---

<!--
Expand All @@ -15,19 +14,14 @@ about: Would you like something work differently? Have an alternative approach?
Head to StackOverflow or https://gitter.im/webpack/webpack.
-->

* Operating System:
* Node Version:
* NPM Version:
* webpack Version:
* less-loader Version:

- Operating System:
- Node Version:
- NPM Version:
- webpack Version:
- less-loader Version:

### Expected Behavior / Situation



### Actual Behavior / Situation



### Modification Proposal
### Modification Proposal
3 changes: 1 addition & 2 deletions .github/ISSUE_TEMPLATE/SUPPORT.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
---
name: 🆘 Support, Help, and Advice
about: 👉🏽 Need support, help, or advice? Don't open an issue! Head to StackOverflow or https://gitter.im/webpack/webpack.

---

Hey there! If you need support, help, or advice then this is not the place to ask.
Please visit [StackOverflow](https://stackoverflow.com/questions/tagged/webpack)
or [the Webpack Gitter](https://gitter.im/webpack/webpack) instead.
or [the Webpack Gitter](https://gitter.im/webpack/webpack) instead.
5 changes: 5 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
/coverage
/dist
/node_modules
/test/fixtures
CHANGELOG.md
Loading

0 comments on commit f0b42b4

Please sign in to comment.