chore: add webpack v5 support, run webpack-defaults #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| "defaults": "webpack-defaults" | ||
| }, | ||
| "files": [ | ||
| "dist" | ||
| ], | ||
| "peerDependencies": { | ||
| "less": "^2.3.1 || ^3.0.0", | ||
| "webpack": "^2.0.0 || ^3.0.0 || ^4.0.0" | ||
| "webpack": "^2.0.0 || ^3.0.0 || ^4.0.0 || ^5.0.0" |
There was a problem hiding this comment.
Let's do it ^4.0.0 || ^5.0.0
ryanclark
commented
Mar 13, 2020
| lessFixturePath('basic.less'), | ||
| ].sort() | ||
| ); | ||
| expect(dependencies).toContain(lessFixturePath('import.less')); |
There was a problem hiding this comment.
webpack 5 adds more dependencies, so we need to check whether or not the loader has added them into the array, rather than the whole array equalling a fixed set of dependencies
alexander-akait
previously approved these changes
Mar 13, 2020
|
audit problem, jest still has old acorn version, so ignore it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Run
webpack-defaultsand validate webpack 5 compatibility, updating tests to passBreaking Changes
N/A