-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(loader): v5.0.0 #233
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
92c78c6
chore: Set peerDeps to 4.x & drop Node 4
joshwiens d1e6d09
ci: Setup to test webpack 4.x
joshwiens 8669c9c
chore: Set engines to initial LTS release version
joshwiens 6d5e95b
refactor: Update to Defaults 2.0
joshwiens 8dd2408
test: Add webpack version check to compiler
joshwiens e378456
refactor: Enforce options schema
joshwiens File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,161 @@ | ||
unit_tests: &unit_tests | ||
steps: | ||
- checkout | ||
- setup_remote_docker | ||
- restore_cache: | ||
key: dependency-cache-{{ checksum "package-lock.json" }} | ||
- run: | ||
name: NPM Rebuild | ||
command: npm install | ||
- run: | ||
name: Run unit tests. | ||
command: npm run ci:test | ||
canary_tests: &canary_tests | ||
steps: | ||
- checkout | ||
- setup_remote_docker | ||
- restore_cache: | ||
key: dependency-cache-{{ checksum "package-lock.json" }} | ||
- run: | ||
name: NPM Rebuild | ||
command: npm install | ||
- run: | ||
name: Install Webpack Canary | ||
command: npm i --no-save webpack@next | ||
- run: | ||
name: Run unit tests. | ||
command: npm run ci:test | ||
|
||
version: 2 | ||
jobs: | ||
dependency_cache: | ||
docker: | ||
- image: webpackcontrib/circleci-node-base:latest | ||
steps: | ||
- checkout | ||
- setup_remote_docker | ||
- restore_cache: | ||
key: dependency-cache-{{ checksum "package-lock.json" }} | ||
- run: | ||
name: Install Dependencies | ||
command: npm install | ||
- save_cache: | ||
key: dependency-cache-{{ checksum "package-lock.json" }} | ||
paths: | ||
- ./node_modules | ||
|
||
node8-latest: | ||
docker: | ||
- image: webpackcontrib/circleci-node8:latest | ||
steps: | ||
- checkout | ||
- setup_remote_docker | ||
- restore_cache: | ||
key: dependency-cache-{{ checksum "package-lock.json" }} | ||
- run: | ||
name: NPM Rebuild | ||
command: npm install | ||
- run: | ||
name: Run unit tests. | ||
command: npm run ci:coverage | ||
- run: | ||
name: Submit coverage data to codecov. | ||
command: bash <(curl -s https://codecov.io/bash) | ||
when: on_success | ||
node6-latest: | ||
docker: | ||
- image: webpackcontrib/circleci-node6:latest | ||
<<: *unit_tests | ||
node9-latest: | ||
docker: | ||
- image: webpackcontrib/circleci-node9:latest | ||
<<: *unit_tests | ||
node8-canary: | ||
docker: | ||
- image: webpackcontrib/circleci-node8:latest | ||
<<: *canary_tests | ||
analysis: | ||
docker: | ||
- image: webpackcontrib/circleci-node-base:latest | ||
steps: | ||
- checkout | ||
- setup_remote_docker | ||
- restore_cache: | ||
key: dependency-cache-{{ checksum "package-lock.json" }} | ||
- run: | ||
name: NPM Rebuild | ||
command: npm install | ||
- run: | ||
name: Run linting. | ||
command: npm run lint | ||
- run: | ||
name: Run NSP Security Check. | ||
command: npm run security | ||
- run: | ||
name: Validate Commit Messages | ||
command: npm run ci:lint:commits | ||
publish: | ||
docker: | ||
- image: webpackcontrib/circleci-node-base:latest | ||
steps: | ||
- checkout | ||
- setup_remote_docker | ||
- restore_cache: | ||
key: dependency-cache-{{ checksum "package-lock.json" }} | ||
- run: | ||
name: NPM Rebuild | ||
command: npm install | ||
- run: | ||
name: Validate Commit Messages | ||
command: npm run release:validate | ||
- run: | ||
name: Publish to NPM | ||
command: printf "noop running conventional-github-releaser" | ||
|
||
version: 2.0 | ||
workflows: | ||
version: 2 | ||
validate-publish: | ||
jobs: | ||
- dependency_cache | ||
- node6-latest: | ||
requires: | ||
- dependency_cache | ||
filters: | ||
tags: | ||
only: /.*/ | ||
- analysis: | ||
requires: | ||
- dependency_cache | ||
filters: | ||
tags: | ||
only: /.*/ | ||
- node8-latest: | ||
requires: | ||
- analysis | ||
- node6-latest | ||
filters: | ||
tags: | ||
only: /.*/ | ||
- node9-latest: | ||
requires: | ||
- analysis | ||
- node6-latest | ||
filters: | ||
tags: | ||
only: /.*/ | ||
- node8-canary: | ||
requires: | ||
- analysis | ||
- node6-latest | ||
filters: | ||
tags: | ||
only: /.*/ | ||
- publish: | ||
requires: | ||
- node8-latest | ||
- node9-latest | ||
filters: | ||
branches: | ||
only: | ||
- master |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
module.exports = { | ||
root: true, | ||
plugins: ['prettier'], | ||
extends: ['@webpack-contrib/eslint-config-webpack'], | ||
rules: { | ||
'prettier/prettier': [ | ||
'error', | ||
{ singleQuote: true, trailingComma: 'es5', arrowParens: 'always' }, | ||
], | ||
}, | ||
}; |
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
# These are the default owners for everything in | ||
# webpack-contrib | ||
@webpack-contrib/org-maintainers | ||
|
||
# Add repository specific users / groups | ||
# below here for libs that are not maintained by the org. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"singleQuote": true, | ||
"trailingComma": "es5", | ||
"arrowParens": "always" | ||
} |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
codecov: | ||
branch: master | ||
coverage: | ||
precision: 2 | ||
round: down | ||
range: 70...100 | ||
status: | ||
project: 'no' | ||
patch: 'yes' | ||
comment: 'off' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
/* eslint-disable */ | ||
const Configuration = { | ||
extends: ['@commitlint/config-angular'], | ||
|
||
rules: { | ||
'body-leading-blank': [1, 'always'], | ||
'footer-leading-blank': [1, 'always'], | ||
'header-max-length': [2, 'always', 72], | ||
'scope-case': [2, 'always', 'lower-case'], | ||
'subject-case': [2, 'never', ['start-case', 'pascal-case', 'upper-case']], | ||
'subject-empty': [2, 'never'], | ||
'subject-full-stop': [2, 'never', '.'], | ||
'type-case': [2, 'always', 'lower-case'], | ||
'type-empty': [2, 'never'], | ||
'type-enum': [ | ||
'build', | ||
'chore', | ||
'ci', | ||
'docs', | ||
'feat', | ||
'fix', | ||
'perf', | ||
'refactor', | ||
'revert', | ||
'style', | ||
'test', | ||
], | ||
}, | ||
}; | ||
|
||
module.exports = Configuration; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If he still actively wants to be pinged for review 😛