Fix cjs #899
Merged
Fix cjs #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
commented
Jan 17, 2022
src/loader.js
Outdated
| @@ -478,5 +486,4 @@ export function pitch(request) { | |||
| }); | |||
| } | |||
|
|
|||
| // eslint-disable-next-line func-names | |||
| export default function () {} | |||
| module.exports = { default: function loader() {}, pitch } | |||
There was a problem hiding this comment.
To keep compatibility, ideally we should refactor it in future
Codecov Report
@@ Coverage Diff @@
## master #899 +/- ##
==========================================
+ Coverage 90.92% 91.23% +0.30%
==========================================
Files 5 5
Lines 804 821 +17
Branches 219 219
==========================================
+ Hits 731 749 +18
+ Misses 67 66 -1
Partials 6 6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
fixes #896
Breaking Changes
No
Additional Info
Types was changed too, due we use commonjs now, but our real code in commonjs too, so types should use namespaces