move node-sass to peerDependencies?

[tomchentw]

Hi, as node-sass currently have some issue with pre-build binaries, I'm wondering that if you have plan to move node-sass to peerDependencies instead of dependencies?

This will allow client to override custom node-sass version without fork the sass-loader project. Just specify "node-sass": "1.0.3" in their package.json and it will load the desired version of node-sass.

[akiran]

@tomchentw, some projects may use other packages like gulp-sass, grunt-sass along with sass-loader, which may depend on different node-sass version. Making node-sass as a peerDependency may cause problem to those projects.

If there is any problem with latest sass-loader (in your case, particular node-sass version dependency ), you can always use previously working sass-loader version until the issues in new version are fixed.

[jhnns]

It's a tricky question. There are pro and cons for both sides. The less-loader decided to move it to peerDependencies...

[jhnns]

I think we should move it to the peerDependencies. There is a greater benefit for most developers to specify the sass version directly (see recent pull-requests and issues regarding node-sass v2).

Now that peerDependencies will not be deprecated.

[akiran]

yes

[jhnns]

done()