-
-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add support for node-sass 7 #1072
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can you accept CLA?
@snitin315 CLA done. |
Note: I made the PR against branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this not working with the latest version v13 as well?
Don't know, I'm stuck on v10 due to other deps (mainly webpack 4). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @alexander-akait
Thanks! I'll wait for the new release :) |
Hey @alexander-akait, just to get a feeling of the timing, do you have an idea of when a new release including this PR will be cut? Thanks! |
@julienma Hello, sorry for delay, today |
@alexander-akait great, waiting for it :) Thank you! |
Thanks for the release! |
This PR contains a:
Motivation / Use-Case
#1002 was incomplete (I guess? because it wasn't working for me, and with this change it does).
With:
Got error:
Breaking Changes
Additional Info