-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve the grammar of the readme #1212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ver nice, thanks a lot ✨ Left a small comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more tweaks and I think we are good to approve this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Thx & congrats on your first contribution!🌟
Looks like CI is failing due to sass/node-sass#3420 and that it might not get fixed in favor of officially marked as unmaintained 🤔 |
This is just a docs change, so we'll merge anyway |
cool, thanks - I'll see if this can be worked around in the meantime by just installing a different version of Python in CI, which'll be easier now that I'm no longer a first-time contributor 🎉 |
Awesome,good stuff 🙏 |
Have opened #1215 to fix the |
This PR contains a:
Motivation / Use-Case
These are a number of small grammar issues I noticed while working on #1211 which I figured I'd do a dedicated PR for - these are not Strictly Better and there are still some improvements that could be made, but they feel like a good start :)
Breaking Changes
This is not a breaking change
Additional Info