Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error message from sass #1231

Merged
merged 4 commits into from
Sep 20, 2024
Merged

fix: error message from sass #1231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
63fa6fd
fix: error message from sass
alexander-akait Sep 20, 2024
cfe210a
fix: better
alexander-akait Sep 20, 2024
5140f22
fix: better
alexander-akait Sep 20, 2024
a65c492
test: udate
alexander-akait Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,14 +889,15 @@ function errorFactory(error) {
let message;

if (error.formatted) {
message = error.formatted.replace(/^Error: /, "");
message = error.formatted.replace(/^(.+)?Error: /, "");
} else {
// Keep original error if `sassError.formatted` is unavailable
({ message } = error);
message = (error.message || error.toString()).replace(/^(.+)?Error: /, "");
}

const obj = new Error(message, { cause: error });

obj.name = error.name;
obj.stack = null;

return obj;
Expand Down
92 changes: 46 additions & 46 deletions test/__snapshots__/loader.test.js.no-node-sass.snap
View file
Open in desktop

Large diffs are not rendered by default.

92 changes: 46 additions & 46 deletions test/__snapshots__/loader.test.js.snap
View file
Open in desktop

Large diffs are not rendered by default.

144 changes: 144 additions & 0 deletions test/__snapshots__/sassOptions-option.test.js.no-node-sass.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1224,6 +1224,78 @@ exports[`sassOptions option should ignore the "url" option ('sass-embedded', 'mo

exports[`sassOptions option should ignore the "url" option ('sass-embedded', 'modern-compiler' API, 'scss' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern' API, 'sass' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
method not found: 'get$iterator' (J.getInterceptor$ax(...).get$iterator is not a function)",
]
`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern' API, 'sass' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern' API, 'scss' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
method not found: 'get$iterator' (J.getInterceptor$ax(...).get$iterator is not a function)",
]
`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern' API, 'scss' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'sass' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
method not found: 'get$iterator' (J.getInterceptor$ax(...).get$iterator is not a function)",
]
`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'sass' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'scss' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
method not found: 'get$iterator' (J.getInterceptor$ax(...).get$iterator is not a function)",
]
`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'scss' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern' API, 'sass' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
arr.flatMap is not a function",
]
`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern' API, 'sass' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern' API, 'scss' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
arr.flatMap is not a function",
]
`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern' API, 'scss' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'sass' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
arr.flatMap is not a function",
]
`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'sass' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'scss' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
arr.flatMap is not a function",
]
`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'scss' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should respect the "outputStyle"/"style" option ('dart-sass', 'legacy' API, 'sass' syntax): css 1`] = `
"@charset "UTF-8";
@import "./file.css";
Expand Down Expand Up @@ -4388,6 +4460,78 @@ exports[`sassOptions option should work with custom scheme import ('sass-embedde

exports[`sassOptions option should work with custom scheme import ('sass-embedded', 'modern-compiler' API, 'scss' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern' API, 'sass' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
]
`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern' API, 'sass' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern' API, 'scss' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
]
`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern' API, 'scss' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'sass' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
]
`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'sass' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'scss' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
]
`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'scss' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern' API, 'sass' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
]
`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern' API, 'sass' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern' API, 'scss' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
]
`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern' API, 'scss' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'sass' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
]
`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'sass' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'scss' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
]
`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'scss' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should work with the "functions" option ('dart-sass', 'legacy' API, 'sass' syntax): css 1`] = `
"h2, h3, h4, h5 {
color: #08c;
Expand Down
144 changes: 144 additions & 0 deletions test/__snapshots__/sassOptions-option.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1404,6 +1404,78 @@ exports[`sassOptions option should ignore the "url" option ('sass-embedded', 'mo

exports[`sassOptions option should ignore the "url" option ('sass-embedded', 'modern-compiler' API, 'scss' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern' API, 'sass' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
method not found: 'get$iterator' (J.getInterceptor$ax(...).get$iterator is not a function)",
]
`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern' API, 'sass' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern' API, 'scss' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
method not found: 'get$iterator' (J.getInterceptor$ax(...).get$iterator is not a function)",
]
`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern' API, 'scss' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'sass' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
method not found: 'get$iterator' (J.getInterceptor$ax(...).get$iterator is not a function)",
]
`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'sass' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'scss' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
method not found: 'get$iterator' (J.getInterceptor$ax(...).get$iterator is not a function)",
]
`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'scss' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern' API, 'sass' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
arr.flatMap is not a function",
]
`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern' API, 'sass' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern' API, 'scss' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
arr.flatMap is not a function",
]
`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern' API, 'scss' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'sass' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
arr.flatMap is not a function",
]
`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'sass' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'scss' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
arr.flatMap is not a function",
]
`;

exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'scss' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should respect the "outputStyle"/"style" option ('dart-sass', 'legacy' API, 'sass' syntax): css 1`] = `
"@charset "UTF-8";
@import "./file.css";
Expand Down Expand Up @@ -5054,6 +5126,78 @@ exports[`sassOptions option should work with custom scheme import ('sass-embedde

exports[`sassOptions option should work with custom scheme import ('sass-embedded', 'modern-compiler' API, 'scss' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern' API, 'sass' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
]
`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern' API, 'sass' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern' API, 'scss' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
]
`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern' API, 'scss' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'sass' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
]
`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'sass' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'scss' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
]
`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'scss' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern' API, 'sass' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
]
`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern' API, 'sass' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern' API, 'scss' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
]
`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern' API, 'scss' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'sass' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
]
`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'sass' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'scss' syntax): errors 1`] = `
[
"ModuleBuildError: Module build failed (from ../src/cjs.js):
Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
]
`;

exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'scss' syntax): warnings 1`] = `[]`;

exports[`sassOptions option should work with the "functions" option ('dart-sass', 'legacy' API, 'sass' syntax): css 1`] = `
"h2, h3, h4, h5 {
color: #08c;
Expand Down
5 changes: 5 additions & 0 deletions test/sass/slash-div.sass
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
.example
color: red

a
font-weight: (4/2)
38 changes: 38 additions & 0 deletions test/sassOptions-option.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,6 +524,44 @@ describe("sassOptions option", () => {

await close(compiler);
});

if (isModernAPI) {
it(`should output a normal error with the wrong "fatalDeprecations" option ('${implementationName}', '${api}' API, '${syntax}' syntax)`, async () => {
const testId = getTestId("language", syntax);
const options = {
implementation,
api,
sassOptions: {
fatalDeprecations: "test",
},
};
const compiler = getCompiler(testId, { loader: { options } });
const stats = await compile(compiler);

expect(getWarnings(stats)).toMatchSnapshot("warnings");
expect(getErrors(stats)).toMatchSnapshot("errors");

await close(compiler);
});

it(`should work with the "fatalDeprecations" option ('${implementationName}', '${api}' API, '${syntax}' syntax)`, async () => {
const testId = getTestId("slash-div", syntax);
const options = {
implementation,
api,
sassOptions: {
fatalDeprecations: ["slash-div"],
},
};
const compiler = getCompiler(testId, { loader: { options } });
const stats = await compile(compiler);

expect(getWarnings(stats)).toMatchSnapshot("warnings");
expect(getErrors(stats)).toMatchSnapshot("errors");

await close(compiler);
});
}
});
});
});
7 changes: 7 additions & 0 deletions test/scss/slash-div.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
.example {
color: red;

a {
font-weight: (4/2);
}
}
Loading