chore: build and package updates to allow use of webpack 3 #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enables "canary" testing of webpack via stages
- Uses org appveyor account - Uses org standard codecov.io
- Adds npm scripts used by defualts builds - Sets engines to webpack standard - Allows webpack 3 rc & final as a peerDep
- Both the Travis & Appveyor files install the node version they need
|
@d3viant0ne Can we release path version today, after merge this? |
|
That's the idea, just tidying up the package quick |
Codecov Report
@@ Coverage Diff @@
## master #475 +/- ##
=========================================
Coverage ? 97.43%
=========================================
Files ? 6
Lines ? 117
Branches ? 0
=========================================
Hits ? 114
Misses ? 3
Partials ? 0Continue to review full report at Codecov.
|
michael-ciniawsky
requested changes
Jun 14, 2017
package.json
Outdated
| "repository": { | ||
| "type": "git", | ||
| "url": "git://github.com/webpack-contrib/sass-loader.git" | ||
| } |
There was a problem hiding this comment.
"bugs": {
"url": "https://github.com/webpack-contrib/sass-loader/issues"
},
"homepage": "https://github.com/webpack-contrib/sass-loader",
package.json
Outdated
| @@ -60,8 +60,8 @@ | |||
| "webpack", | |||
| "loader" | |||
| ], | |||
| "repository": { | |||
There was a problem hiding this comment.
This can still stay :)
michael-ciniawsky
approved these changes
Jun 14, 2017
michael-ciniawsky
changed the title
michael-ciniawsky
added
status: Approved
and removed
priority: 3 (required)
pr_action: Review
severity: 4 (inconvenient)
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #471