Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report error to user for problems loading node-sass #562

Merged
merged 2 commits into from
Apr 24, 2018

Conversation

acouch
Copy link
Contributor

@acouch acouch commented Apr 23, 2018

This addresses #561

This provides the full error instead of:

sass-loader` requires `node-sass` >=4. Please install a compatible version..

When I had the wrong node-sass binding for my version of Linux I get the following with this PR:

Module build failed: Error: Missing binding /node_modules/node-sass/vendor/linux-x64-51/binding.node
Node Sass could not find a binding for your current environment: Linux 64-bit with Node.js 7.x

Which directed me to the actual problem.

@jsf-clabot
Copy link

jsf-clabot commented Apr 23, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 23, 2018

Codecov Report

Merging #562 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #562   +/-   ##
=======================================
  Coverage   97.58%   97.58%           
=======================================
  Files           6        6           
  Lines         124      124           
=======================================
  Hits          121      121           
  Misses          3        3
Impacted Files Coverage Δ
lib/loader.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2759618...767be08. Read the comment docs.

@alexander-akait
Copy link
Member

/cc @jhnns

@jhnns jhnns merged commit 2529c07 into webpack-contrib:master Apr 24, 2018
@jhnns
Copy link
Member

jhnns commented Apr 24, 2018

Awesome 👍 this makes totally sense and sorry for hiding the original error.

@svewag
Copy link

svewag commented May 15, 2018

When will this change be released?

@alexander-akait
Copy link
Member

in 7 version

@svewag
Copy link

svewag commented May 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants