Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prefer scss, sass and css extension in resolving #645

Merged
merged 1 commit into from
Dec 14, 2018

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Dec 13, 2018

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Prefer scss, sass and css extensions in resolving. Partial #556

Breaking Changes

No

Additional Info

Resolve already return promise, no need pify

@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #645 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #645      +/-   ##
==========================================
+ Coverage   97.79%   97.84%   +0.04%     
==========================================
  Files           6        6              
  Lines         136      139       +3     
==========================================
+ Hits          133      136       +3     
  Misses          3        3
Impacted Files Coverage Δ
lib/loader.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2adcca3...f41f791. Read the comment docs.

@HairyRabbit
Copy link

nice work!
and ..
would the exts configueable or some way If I want to load json or yaml file from scss file

@alexander-akait
Copy link
Member Author

@HairyRabbit out of scope this PR, node-sass and dart-sass doesn't support json/yaml and etc options, so it is out of scope repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants