Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: code #742

Merged
merged 1 commit into from
Aug 23, 2019
Merged

refactor: code #742

merged 1 commit into from
Aug 23, 2019

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Refactor code

Breaking Changes

No, but error message now is difference for node-sass and sass because it is difference implementation and have difference errors

Additional Info

No

@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #742 into next will increase coverage by 1.1%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             next     #742     +/-   ##
=========================================
+ Coverage   96.36%   97.46%   +1.1%     
=========================================
  Files           7        9      +2     
  Lines         165      158      -7     
  Branches       56       55      -1     
=========================================
- Hits          159      154      -5     
+ Misses          6        4      -2
Impacted Files Coverage Δ
src/getRenderFunctionFromSassImplementation.js 100% <100%> (ø)
src/getSassOptions.js 100% <100%> (ø) ⬆️
src/SassError.js 100% <100%> (ø)
src/webpackImporter.js 100% <100%> (ø) ⬆️
src/index.js 100% <100%> (+5.79%) ⬆️
src/importsToResolve.js 100% <100%> (ø) ⬆️
src/getDefaultSassImplementation.js 55.55% <55.55%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 716de3c...81f042e. Read the comment docs.

@alexander-akait alexander-akait force-pushed the refactor-code branch 5 times, most recently from a0995f6 to da1dca9 Compare August 23, 2019 12:41
@alexander-akait alexander-akait merged commit 33a23f8 into next Aug 23, 2019
@alexander-akait alexander-akait deleted the refactor-code branch August 23, 2019 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant