Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(index): enable HMR in case locals (css-modules) are unchanged #298

Merged
merged 6 commits into from
Jan 26, 2018
Merged

fix(index): enable HMR in case locals (css-modules) are unchanged #298

merged 6 commits into from
Jan 26, 2018

Commits on Jan 26, 2018

  1. fix: Allow css-modules HMR when classes are unchanged 

    Fixes webpack-contrib/css-loader#669.

Previously, HMR was disabled if css-modules was enabled (in css-loader)
and at least one class was present in the file. This was because JS
files depend on the classes, and as such have to be reloaded when the
CSS changes in case the classes have changed.

Now, HMR _is_ used if no classes change. Othewise the whole page is
reloaded like before.
    @lydell
    lydell committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    9d96c43 View commit details
    Browse the repository at this point in the history

  2. Shorten some code

    @lydell
    lydell committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    3bb5ae5 View commit details
    Browse the repository at this point in the history

  3. ES3 (IE8) support

    @lydell
    lydell committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    19ba925 View commit details
    Browse the repository at this point in the history

  4. Use worse variable names

    @lydell
    lydell committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    1007d40 View commit details
    Browse the repository at this point in the history

  5. Add missing semicolon

    @lydell
    lydell committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    b516fc0 View commit details
    Browse the repository at this point in the history

  6. Add another missing semicolon

    @lydell
    lydell committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    0d52dee View commit details
    Browse the repository at this point in the history