feat: enable tag type configuration #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #316 +/- ##
=======================================
Coverage 98.43% 98.43%
=======================================
Files 4 4
Lines 64 64
Branches 21 21
=======================================
Hits 63 63
Misses 1 1Continue to review full report at Codecov.
|
ooflorent
approved these changes
Apr 17, 2018
alexander-akait
approved these changes
Apr 17, 2018
alexander-akait
added
pr_action: Merge ready
status: Approved
and removed
flag: Needs Tests
pr_action: Rework
labels
This was referenced Apr 19, 2018
This was referenced Nov 7, 2019
This was referenced Apr 1, 2020
This was referenced Apr 23, 2020
This was referenced May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Small feature
Did you add tests for your changes?
Yes.
If relevant, did you update the README?
No.
Summary
This lets projects using style-loader define the type of the style or link tags in the
attrsoption of the loader, along with other tag attributes. See style-loader/issues/315Does this PR introduce a breaking change?
No.
Other information