Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insertInto and insertAt collaboration bug fixed #325

Merged
merged 1 commit into from
May 8, 2018

Conversation

Vasikaran
Copy link
Contributor

@Vasikaran Vasikaran commented May 7, 2018

What kind of change does this PR introduce?

Bugfix

Did you add tests for your changes?
Yes, added test case too.

If relevant, did you update the README?
No need to update README.

Summary
When using insertInto ( as a function ) and insertAt (as an object), the compiled code would throw an error in console. In this PR, I've changed source code slightly and without affecting existing workflow.

An issue I've raised in recent. #313

Does this PR introduce a breaking change?

No. Testing well. And test case also got 100 percentage result.

Other information
Hope you will accept my PR ASAP. Casue, we've a recuirement based on this.

@jsf-clabot
Copy link

jsf-clabot commented May 7, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Vasikaran S seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@codecov
Copy link

codecov bot commented May 7, 2018

Codecov Report

Merging #325 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #325   +/-   ##
=======================================
  Coverage   98.43%   98.43%           
=======================================
  Files           4        4           
  Lines          64       64           
  Branches       21       21           
=======================================
  Hits           63       63           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4fa68a...ef2a600. Read the comment docs.

@alexander-akait
Copy link
Member

@Vasikaran you should accept CLA

@Vasikaran
Copy link
Contributor Author

@evilebottnawi I've signed in CLA. But the label didn't change. That shows Not signed yet

@alexander-akait
Copy link
Member

@Vasikaran

Vasikaran S seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@Vasikaran
Copy link
Contributor Author

@evilebottnawi I see nothing to add my email address in this commit.

@alexander-akait
Copy link
Member

@Vasikaran address in commit is difference what you use for github

@Vasikaran
Copy link
Contributor Author

@evilebottnawi I think finally I did that.

@alexander-akait
Copy link
Member

@Vasikaran need second eyes and we can merge

@Vasikaran
Copy link
Contributor Author

@evilebottnawi What did you mean second eyes? I can't understand.

Copy link

@ooflorent ooflorent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@alexander-akait alexander-akait merged commit c7d8fec into webpack-contrib:master May 8, 2018
@Vasikaran
Copy link
Contributor Author

@evilebottnawi @ooflorent Kindly publish this at least as a patch version like 0.21.1. Till now I wasn't able to use this two options at the same time.

@alexander-akait
Copy link
Member

@Vasikaran in todo, try to find time today 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants