-
-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
insertInto and insertAt collaboration bug fixed #325
Conversation
Vasikaran S seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
=======================================
Coverage 98.43% 98.43%
=======================================
Files 4 4
Lines 64 64
Branches 21 21
=======================================
Hits 63 63
Misses 1 1 Continue to review full report at Codecov.
|
@Vasikaran you should accept CLA |
@evilebottnawi I've signed in CLA. But the label didn't change. That shows Not signed yet |
|
@evilebottnawi I see nothing to add my email address in this commit. |
@Vasikaran address in commit is difference what you use for github |
@evilebottnawi I think finally I did that. |
@Vasikaran need second eyes and we can merge |
@evilebottnawi What did you mean second eyes? I can't understand. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@evilebottnawi @ooflorent Kindly publish this at least as a patch version like 0.21.1. Till now I wasn't able to use this two options at the same time. |
@Vasikaran in todo, try to find time today 👍 |
What kind of change does this PR introduce?
Bugfix
Did you add tests for your changes?
Yes, added test case too.
If relevant, did you update the README?
No need to update README.
Summary
When using insertInto ( as a function ) and insertAt (as an object), the compiled code would throw an error in console. In this PR, I've changed source code slightly and without affecting existing workflow.
An issue I've raised in recent. #313
Does this PR introduce a breaking change?
No. Testing well. And test case also got 100 percentage result.
Other information
Hope you will accept my PR ASAP. Casue, we've a recuirement based on this.