fix: injection algorithm #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #456 +/- ##
==========================================
+ Coverage 98.95% 99.06% +0.11%
==========================================
Files 4 4
Lines 192 215 +23
Branches 88 92 +4
==========================================
+ Hits 190 213 +23
Misses 2 2
Continue to review full report at Codecov.
|
This was referenced Mar 21, 2020
This was referenced Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
partial #450
Breaking Changes
No
Additional Info
Some cases still broken and need fix:
@importin two difference modules collapsed in one, we should fix it in css-loader, maybe add 4th argument for all@import, it is allow to distinguish css modules import from@import@importit can create invalid order (rare use case)