Add support for 'insertAt' parameter #69
Conversation
|
please use tabs instead of spaces... :) |
|
Woops, somehow I didn't notice that. I changed the spaces to tabs. |
| head.insertBefore(styleElement, head.firstChild); | ||
| } else if (options.insertAt === "bottom") { | ||
| head.appendChild(styleElement); | ||
| } |
There was a problem hiding this comment.
What do you think of this for the error text: "Invalid value for parameter 'insertAt'. Must be 'top' or 'bottom'."
|
https://github.com/substack/insert-css has "prepend" mode which I do find a good naming. What do you think @elsbree? |
|
Seems like that would mostly be a question of semantics. The 'insertAt' parameter has the advantage of being more flexible, that is, we could allow options other than just 'top' or 'bottom' in the future. That being said, I don't have a strong preference either way. |
|
+1 |
| @@ -45,6 +45,10 @@ Note: Behavior is undefined when `unuse`/`unref` is called more often than `use` | |||
|
|
|||
| ### Options | |||
|
|
|||
| #### `insertAt` | |||
|
|
|||
| By default, the style-loader appends `<style>` elements to the end of the `<head>` tag of the page. This will cause CSS created by the loader to take priority over CSS already present in the document head. To insert style elements at the beginning of the head, set this query parameter to 'bottom', e.g. `require('../style.css?insertAt=bottom')`. | |||
There was a problem hiding this comment.
- 'bottom', e.g. `require('../style.css?insertAt=bottom')`
+ 'top', e.g. `require('!style?insertAt=bottom!css!../style.css')`
Add support for 'insertAt' parameter
|
Thanks |
|
Hmm... It's broken, because style tags are in incorrect order. i. e. require("a.css");
require("b.css");bottom: <head>
<style src="existing"></style>
<style>... a.css ...</style>
<style>... b.css ...</style>
</head>top: <head>
<style>... b.css ...</style>
<style>... a.css ...</style>
<style src="existing"></style>
</head>and the order is important... Could you do a follow-up PR that fix this, i. e. by storing a list of all top-inserted style tags and inserting after the last one. Keep in mind that |
|
Oh, good catch. Yep, I can work on that. |
Implemented for #56. Adds an 'insertAt' parameter that lets you specify where you would like to insert the style tags in the head, either 'top' or 'bottom' (the default). This lets you avoid taking priority over any CSS already in the head if you so desire.