Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stylelint prefix to CLI output for better debugging #273

Merged
merged 3 commits into from
May 20, 2022

Conversation

ricardogobbosouza
Copy link
Collaborator

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Resolve #270

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #273 (50c0a9f) into master (da40303) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #273   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          249       249           
  Branches        53        53           
=========================================
  Hits           249       249           
Impacted Files Coverage Δ
src/StylelintError.js 100.00% <100.00%> (ø)
src/linter.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da40303...50c0a9f. Read the comment docs.

snitin315
snitin315 previously approved these changes Apr 30, 2022
@@ -3,7 +3,7 @@ class StylelintError extends Error {
* @param {string=} messages
*/
constructor(messages) {
super(messages);
super(`\u001b[1;31m[stylelint]\u001b[1;0m ${messages}`);
Copy link
Member

@alexander-akait alexander-akait Apr 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to respect stats.colors option, because some developers disable colors, but it is error, so maybe it is good

@ricardogobbosouza ricardogobbosouza merged commit 4ce7da3 into master May 20, 2022
@ricardogobbosouza ricardogobbosouza deleted the feat-stylelint-prefix branch May 20, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add [stylelint] prefix to CLI output for better debugging
3 participants