fix: move webpack to a peer dependency and allow webpack 2

[mattlewis92]

Using this plugin with webpack 2 currently installs 2 versions of webpack.

Resolves #38.

[coveralls]

Coverage remained the same at 95.238% when pulling a4d9ff8 on mattlewis92:patch-1 into e6cf081 on vieron:master.

[JaKXz]

Thanks for the PR. The only thing I'm wondering about now is how can we test against both webpack v1 and v2 so that it ships and is working for both?

[JaKXz]

I'd rather just have ^2.0.0 || ^1.13.2 here... I would think it's better to just "officially" support stable versions. With npm >=3 or yarn you won't get peerDeps installed anyway so you can still choose what version you want.

[mattlewis92]

There are no breaking changes between webpack 1 and webpack 2's API that would affect this plugin, it's very safe to support the beta versions of webpack, and gets rid of the annoying peer dependency warning on install.

[JaKXz]

I see, because the rc and beta versions do not fall under semver technically so they aren't resolved by ^2.0.0? Fair enough.

[coveralls]

Coverage remained the same at 95.238% when pulling 8789da9 on mattlewis92:patch-1 into e6cf081 on vieron:master.

[mattlewis92]

@JaKXz I've added a simple npm script to test against both v1 and v2 of webpack, LMK what you think.

[mattlewis92]

Yup that's correct, this is how all the webpack plugins have their peer dependency set under the webpack org

…

On 18 Dec 2016, at 16:36, Jason Kurian ***@***.***> wrote: @JaKXz commented on this pull request. In package.json: > @@ -23,14 +23,14 @@ }, "homepage": "https://github.com/vieron/stylelint-webpack-plugin#readme", "peerDependencies": { - "stylelint": "^7.0.1" + "stylelint": "^7.0.1", + "webpack": "^2 || ^2.2.0-rc.0 || ^2.1.0-beta.0 || ^1.13.2" I see, because the rc and beta versions do not fall under semver technically so they aren't resolved by ^2.0.0? Fair enough. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[coveralls]

Coverage remained the same at 95.238% when pulling a13d6ca on mattlewis92:patch-1 into 6b74bb6 on vieron:master.

[mattlewis92]

@JaKXz I just spotted there was a merge conflict with master which I've now resolved, would you like me to make any more changes before this can be merged? 😃

[JaKXz]

@mattlewis92 thanks for fixing that!

I'm still not sure about the way to test the different versions of webpack though. Maybe this should be a bigger discussion with @sokra and other plugin maintainers who want to maintain backwards compatibility?

[mattlewis92]

Given that webpack 2 is now in RC and there are no more breaking changes planned (and previously none that have affected this plugin) - I wouldn't worry too much about it. AFAIK the plugin / loader API will always be pretty stable to avoid breaking the webpack ecosystem - the majority of breaking changes are in the EU's webpack config itself. Maybe @TheLarkInn can give some more insight into this though?

[JaKXz]

@mattlewis92 thank you for your patience on this!

I had a look at the long thread that is npm/npm#5499 and found: https://github.com/scott113341/npm-install-version

I think a programmatic solution with npm-install-version is the way to go - at first glance it looks like a sustainable way to test against both versions of webpack until webpack 1 support is dropped, which of course isn't happening any time soon.

I really appreciate your work on this - let me know if you want to give that a shot or I can take it on if you're spent. :)

[coveralls]

Coverage increased (+0.2%) to 95.455% when pulling a9d6b2b on mattlewis92:patch-1 into 6b74bb6 on vieron:master.

[mattlewis92]

@JaKXz I've done a basic implementation using npm-install-version - let me know if that's OK for you

[coveralls]

Coverage increased (+0.2%) to 95.455% when pulling cadc39a on mattlewis92:patch-1 into 6b74bb6 on vieron:master.

[JaKXz]

+ stylelint-webpack-plugin@0.5.0 published! thanks again!

[mattlewis92]

Awesome, thanks! 😃