test: resolving (#245)

src/index.js

@@ -1,3 +1,5 @@
+import path from 'path';
+
 import stylus from 'stylus';
 
 import { getOptions } from 'loader-utils';
@@ -93,15 +95,15 @@ export default async function stylusLoader(source) {
   // let stylus do its magic
   styl.render(async (error, css) => {
     if (error) {
-      this.addDependency(error.filename);
+      this.addDependency(path.normalize(error.filename));
       return callback(error);
     }
 
     // eslint-disable-next-line no-underscore-dangle
     if (stylusOptions._imports.length) {
       // eslint-disable-next-line no-underscore-dangle
       for (const importData of stylusOptions._imports) {
-        this.addDependency(importData.path);
+        this.addDependency(path.normalize(importData.path));
       }
     }
 

test/fixtures/import-binop.styl

@@ -0,0 +1,2 @@
+@import "deep/" + "import-" + "fakenib"
+

test/fixtures/shallow-indent.styl

@@ -0,0 +1,8 @@
+body
+  color: red
+
+.some-class
+  @import "basic.styl"
+
+.webpack-import
+  @import "deep/import-fakenib"

test/helpers/index.js

@@ -7,6 +7,7 @@ import getWarnings from './getWarnings';
 import normalizeErrors from './normalizeErrors';
 import readAsset from './readAsset';
 import readsAssets from './readAssets';
+import validateDependencies from './validateDependencies';
 
 export {
   compile,
@@ -18,4 +19,5 @@ export {
   normalizeErrors,
   readAsset,
   readsAssets,
+  validateDependencies,
 };

test/helpers/validateDependencies.js

@@ -0,0 +1,13 @@
+const illegalSymbol = process.platform === 'win32' ? '/' : '\\';
+
+export default (dependencies) => {
+  for (const item of Array.from(dependencies)) {
+    if (item.includes(illegalSymbol)) {
+      throw new Error(
+        `The file path "${item}" should not contain "${illegalSymbol}"`
+      );
+    }
+  }
+
+  return true;
+};

test/loader.test.js

@@ -6,6 +6,7 @@ import {
   getCompiler,
   getErrors,
   getWarnings,
+  validateDependencies,
 } from './helpers';
 
 describe('loader', () => {
@@ -205,6 +206,67 @@ describe('loader', () => {
     expect(getErrors(stats)).toMatchSnapshot('errors');
   });
 
+  it.skip('should work indented import', async () => {
+    const testId = './shallow-indent.styl';
+    const compiler = getCompiler(testId);
+    const stats = await compile(compiler);
+    const codeFromBundle = getCodeFromBundle(stats, compiler);
+    const { fileDependencies } = stats.compilation;
+
+    validateDependencies(fileDependencies);
+
+    const fixturesDir = path.resolve(__dirname, 'fixtures');
+    const fixtures = [
+      path.resolve(fixturesDir, 'basic.styl'),
+      path.resolve(fixturesDir, 'deep', 'import-fakenib.styl'),
+      path.resolve(fixturesDir, 'node_modules', 'fakenib', 'index.styl'),
+      path.resolve(fixturesDir, 'shallow-indent.styl'),
+    ];
+
+    /*
+     * Todo for webpack@5
+     * when ...node_modules/stylus/lib/functions/index.styl breaks fileDependencies
+     * */
+
+    fixtures.forEach((fixture) => {
+      expect(fileDependencies.has(fixture)).toBe(true);
+    });
+
+    expect(codeFromBundle.css).toMatchSnapshot('css');
+    expect(getWarnings(stats)).toMatchSnapshot('warnings');
+    expect(getErrors(stats)).toMatchSnapshot('errors');
+  });
+
+  it.skip('should work binop import', async () => {
+    const testId = './import-binop.styl';
+    const compiler = getCompiler(testId);
+    const stats = await compile(compiler);
+    const codeFromBundle = getCodeFromBundle(stats, compiler);
+    const { fileDependencies } = stats.compilation;
+
+    validateDependencies(fileDependencies);
+
+    const fixturesDir = path.resolve(__dirname, 'fixtures');
+    const fixtures = [
+      path.resolve(fixturesDir, 'deep', 'import-fakenib.styl'),
+      path.resolve(fixturesDir, 'node_modules', 'fakenib', 'index.styl'),
+      path.resolve(fixturesDir, 'import-binop.styl'),
+    ];
+
+    /*
+     * Todo for webpack@5
+     * when ...node_modules/stylus/lib/functions/index.styl breaks fileDependencies
+     * */
+
+    fixtures.forEach((fixture) => {
+      expect(fileDependencies.has(fixture)).toBe(true);
+    });
+
+    expect(codeFromBundle.css).toMatchSnapshot('css');
+    expect(getWarnings(stats)).toMatchSnapshot('warnings');
+    expect(getErrors(stats)).toMatchSnapshot('errors');
+  });
+
   it('in a nested import load module from node_modules', async () => {
     const testId = './shallow-fakenib.styl';
     const compiler = getCompiler(testId);