Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shouldn’t the type hints for stylusOptions.include and stylusOptions.import be changed to string[]? #420

Closed
1 of 4 tasks
zavierkolten opened this issue Aug 14, 2024 · 2 comments
Closed
1 of 4 tasks

Shouldn’t the type hints for stylusOptions.include and stylusOptions.import be changed to string[]? #420

zavierkolten opened this issue Aug 14, 2024 · 2 comments

Comments

@zavierkolten
Copy link
Contributor

Documentation Is:

  • Missing
  • Needed
  • Confusing
  • Not Sure?

Please Explain in Detail...

stylusOptions.include and stylusOptions.import seems like it should be an array, but the documentation states that it should be a string.
image

When I pass in a string, its behavior doesn’t seem to be as expected.

webpack config:
image

stylus loader breakpoint:
image

Your Proposal for Changes

Change these two types to string[].
@alexander-akait
Copy link
Member

PR welcome

zavierkolten added a commit to zavierkolten/stylus-loader that referenced this issue Aug 16, 2024
@zavierkolten
docs: correct type definitions of include and import fields (close:
3ddf2da 
webpack-contrib#420)
zavierkolten added a commit to zavierkolten/stylus-loader that referenced this issue Aug 16, 2024
@zavierkolten
docs: correct type definitions of include and import (close: webp…
92f155c 
…ack-contrib#420)
@zavierkolten
Copy link
Contributor Author

@alexander-akait PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexander-akait @zavierkolten